Problem/Motivation

When using cron on 7.x-3.x no content types are found and cron returns empty

Proposed resolution

Implement the currently commented out function node_revision_delete_content_types();

Remaining tasks

Write function for node_revision_delete_content_types() likely based on the the variable node_revision_delete_track.

Keep in mind that the current function for _node_revision_delete_do_delete is strictly looking at a minimum revisions to keep and doesn't take into account the date values. May need to convert this function to accept an array and adjustments as well.

User interface changes

None.

API changes

None.

Data model changes

None.

Comments

kbasarab created an issue. See original summary.

adriancid’s picture

Assigned: Unassigned » adriancid
Issue summary: View changes

@kbasarab thanks for reporting (and for use the template :-) ), as I changing many things in the module I just forget to update the cron functionality :-(, I just tested that the 'Delete revisions now ' functionality in the Config Page was working.

I will fix this in a few minutes.

If you found another thing that you think that should be improved, write another issue ;-)

  • adriancid committed 4d0df0c on 7.x-3.x
    Issue #2888840 by kbasarab, adriancid: Cron fails with no content types...
adriancid’s picture

Issue summary: View changes
Status: Active » Needs review

@kbasarab I fixed the problem (or at least I think that is solved) I do dome test and it works fine, can you do some test in your side?

If you have some drupal7 or drupal8 database with revisions this will help with the test, at this moment I don't have a big database to test the module.

If you see that all is fine, let my know to close this issue ;-)

kbasarab’s picture

Status: Needs review » Fixed

Hey @adriancid. All looks good on the 7.x-3.x branch. Confirmed on a larger D7 site. Closing out.

adriancid’s picture

thanks @kbasarab, if you can provide me a large site for test (D7 and/or D8) you will really help me with the development.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

adriancid’s picture