Hello,

I think that is best idea that input opacity will be number instead of textfield. Number FAPI allow set max and min and step. It's more intuitive to edit content.

I attached a patch.

CommentFileSizeAuthor
#2 color_field-input_number-2887091-1.patch4 KBeloivaque
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

eloiv created an issue. See original summary.

eloivaque’s picture

eloivaque
Primary language Catalan
Location Catalan Countries
CreditAttribution: eloivaque at Omitsis Consulting SL, Lliures.cat for Lliures.cat, Omitsis Consulting SL commented
FileSize
color_field-input_number-2887091-1.patch4 KB

credits

nord102’s picture

nord102
he/him
Primary language English
CreditAttribution: nord102 commented
Status: Active » Needs review

Patch tested. Applied cleanly. Functionality would most definitely help content entry and edit.

nord102’s picture

nord102
he/him
Primary language English
CreditAttribution: nord102 commented
Status: Needs review » Reviewed & tested by the community

  • NickWilde committed 7bed268 on 8.x-2.x 
    Issue #2887091 by eloiv, NickWilde: Opacity input number, step 0,1, min...
NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde at BriarMoon Design commented
Status: Reviewed & tested by the community » Fixed

Unfortunately, other commits made this not apply cleanly. However, I totally agree it is way better to use the correct html input type. I manually applied the changes and did a couple further changes:
- changed the step value to 0,01; allows more specific opacity values.
- removed the maxlength/size attributes as HTML5 number inputs don't use those.
Anyways, thanks for the patch! Finally committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.