While reviewing #2853872: Migration for forum and article comments: duplicate comment types and incorrect comment_entity_statistics, I realized that Migrate Drupal is creating a new comment type for every single node type that is migrated from Drupal 7. This results in a bunch of cruft, and an extraordinarily confusing migration path for anything related to D7 comments. I discovered that this is largely my fault, as #2532534: Migration Files for Drupal 7 Comments is what introduced the wonky and janky d7_comment_type migration.
Now, I propose to right this wrong. There is no realistic reason for there to be a comment type per node type -- the migration should instead emulate what Standard does, which is...create a single comment type, called 'comment', and a second one for forum posts (which Forum is hard-coded to use, as detailed in #2853872: Migration for forum and article comments: duplicate comment types and incorrect comment_entity_statistics), if there is a 'forum' content type in the D7 source database. This will greatly simplify things and help untangle the Comment migration path from D7.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2886839-2.patch | 2.86 KB | phenaproxima |
Comments
Comment #2
phenaproximaA first pass. Almost guaranteed to fail the tests. Joy!
Comment #4
masipila CreditAttribution: masipila as a volunteer commentedHi,
We don't need to create the comment_forum comment type in the d7_comment_type migration since comment_forum is created automatically when the D8 Forum module is installed.
Cheers,
Markus
Comment #5
masipila CreditAttribution: masipila as a volunteer commentedThere are more issues than what I commented in the previous comment. I'm now evaluating these and will post my findings here...
Comment #6
masipila CreditAttribution: masipila as a volunteer commentedClosing as WONTFIX based on the IRC discussion with phenaproxima today. See https://www.drupal.org/node/2853872#comment-12132701 for the summary of the discussion.