Support for D6 user reference fields was added in #2447729: Migrate D6 user reference fields to D8 entity reference field storage config entities, but that only migrates the field definitions into D8. We still don't have the final puzzle piece, which is migrating the user reference field values from D6 to D8. Let's add that.

CommentFileSizeAuthor
#5 2886801-2-FAIL.patch898 bytesphenaproxima
#2 2886801-2.patch2.06 KBphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
StatusFileSize
new 2886801-2.patch2.06 KB

Here we go! With tests. Aw yeah.

maxocub’s picture

maxocub commented
Status: Needs review » Reviewed & tested by the community

Quite straightforward, I don't see anything wrong, good work!

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue tags: +DrupalCampMontréal2017
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2886801-2-FAIL.patch898 bytes

At @catch's request, here's a failing test-only version of #2.

Status: Needs review » Needs work

The last submitted patch, 5: 2886801-2-FAIL.patch, failed testing. View results

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Reviewed & tested by the community

Failed as expected, so back to RTBC for #2.

  • catch committed e96b787 on 8.4.x 
    Issue #2886801 by phenaproxima: Migrate D6 user reference values to D8
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.4.x, thanks!

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.4.x-dev » 8.3.x-dev
Status: Fixed » Reviewed & tested by the community

This should go into 8.3.x too.

  • catch committed e77fbee on 8.3.x 
    Issue #2886801 by phenaproxima: Migrate D6 user reference values to D8...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Cherry-picked to 8.3.x, thanks!

catch’s picture

catch
he/him
Primary language English
commented
Priority: Normal » Major
Issue tags: +Migrate critical

Also retrospective priority/tag, this is massive :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.