Problem/Motivation

Modules are supposed to provide a Help text page per the HELP text standards for Core and Contrib. Even though Entity API does not provide a user interface it would be helpful to include with it a quick description about the module and how its used.

Proposed resolution

Write a help text according to https://www.drupal.org/node/632280

Remaining tasks

Review/Comment on patch(es).

User interface changes

Improves the UI

Comments

dbt102 created an issue. See original summary.

dbt102’s picture

StatusFileSize
new3.71 KB
dbt102’s picture

Assigned: dbt102 » Unassigned
Status: Active » Needs review
dbt102’s picture

Issue summary: View changes
dbt102’s picture

Issue summary: View changes
krina.addweb’s picture

Status: Needs review » Needs work
StatusFileSize
new15.77 KB
new16.84 KB
new152.74 KB

@dbt102, Thanks for providing patch, It works for Help Page but when I checked for :

+    case 'admin/structure/entity/add':
+      return '<p>' . t('Use this page to create a new custom block.') . '</p>';
+  }
+  if ($arg[0] == 'admin' && $arg[1] == 'structure' && $arg['2'] == 'block' && (empty($arg[3]) || $arg[3] == 'list')) {
+    $demo_theme = !empty($arg[4]) ? $arg[4] : variable_get('theme_default', 'bartik');
+    $themes = list_themes();
+    $output = '<p>' . t('This page provides a drag-and-drop interface for assigning a block to a region, and for controlling the order of blocks within regions. Since not all themes implement the same regions, or display regions in the same way, blocks are positioned on a per-theme basis. Remember that your changes will not be saved until you click the <em>Save blocks</em> button at the bottom of the page. Click the <em>configure</em> link next to each block to configure its specific title and visibility settings.') . '</p>';
+    $output .= '<p>' . l(t('Demonstrate block regions (!theme)', array('!theme' => $themes[$demo_theme]->info['name'])), 'admin/structure/entity/demo/' . $demo_theme) . '</p>';
+    return $output;
+  }
+}

I didn't find any link to check the changes from Structure.

dbt102’s picture

oops ... thanks@krina.addweb ... that shouldn't be there ... new patch with interdiff attached

dbt102’s picture

Status: Needs work » Needs review
krina.addweb’s picture

Status: Needs review » Reviewed & tested by the community

@dbt102, Perfect Thanks!.. now it works well as I checked it with Simplytest.me.

joseph.olstad’s picture

nice , thanks!

tr’s picture

StatusFileSize
new2.63 KB

#7 no longer applies in DrupalCI because of fuzz in the patch. Here is a re-roll. Also has the whitespace error removed (coding standards).

tr’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to 7.x-1.x. This should also be forward-ported to 8.x-1.x.

  • TR committed 2bb5f9b on 7.x-1.x
    Issue #2886570 by dbt102, TR, krina.addweb: Add_Entity_Help
    
tr’s picture

Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Patch (to be ported) » Needs review
StatusFileSize
new3.72 KB

I should have reviewed the patch more carefully. Here are a few changes that need to be made.

I changed the help URL to point to the Entity API documentation guide instead of the core Drupal Entity API guide. This help should be about the Entity API module, not about the core Entity API.

I removed extraneous white space from some strings.

I removed an unused parameter (@blocks) in the second argument to a t() call.

  • TR committed 7802c0b on 7.x-1.x
    Issue #2886570 by dbt102, TR, krina.addweb: Add_Entity_Help - follow-up...
tr’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Needs review » Patch (to be ported)