Similar to d7, d8 file_validate_image_resolution removes exif data if image is too big, which breaks this module.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2344175-max-set-patch-applied.png | 19.07 KB | othermachines |
| #4 | 2344175-max-set.png | 19.04 KB | othermachines |
| #3 | interdiff.txt | 536 bytes | strykaizer |
| #3 | 2886469-3.patch | 1.51 KB | strykaizer |
Comments
Comment #2
strykaizerPatch attached.
This should work for all form widgets using exif_orientation_validate_image_rotation as upload_validator
Comment #3
strykaizerC/P fix
Comment #4
othermachines commentedI can confirm that patch in #3 also fixes the issue in #2344175: EXIF data gets stripped when using Maximum image resolution where exif data is lost if a maximum image resolution is set (which makes sense).
Edit: tested on clean 8.5.0 installation with exif_orientation 8.x-1.x-dev.
With Maximum image resolution set to 500x500 on image field:
Before patch:
After patch:
A working patch for 7.x is in aforementioned issue.
This should probably have tests, though? I'll update the issue. Thanks!
Comment #5
chrisolofAlso confirming the patch in #3 works well.
Comment #6
strykaizersetting rtbc as per 2 previous comments
Comment #7
mglamanThanks, all. I'll go commit shortly.
Comment #9
mglamanFixed, tagged 1.0.