Closed (fixed)
Project:
Logo Block
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
15 Jun 2017 at 11:54 UTC
Updated:
14 Jul 2017 at 15:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
volegerComment #3
volegerIf you have an idea how to move
theme_logo_block_image_style()intologo_block.theme.incfile feel free to provide updated patch.Comment #4
ordermind commentedThanks for the patch, it looks good on the whole so I'll just test it and make some minor changes like putting the theme function in the .theme.inc file. Btw, why did you add a line break to the description on line 52?
Comment #5
volegerThere is a few coding standards error:
logo_block.module:44 - phpcs: Closing parenthesis of array declaration must be on a new line.
logo_block.module:44 - phpcs: Closing parenthesis of array declaration must be on a new line.
logo_block.module:44 - phpcs: A comma should follow the last multiline array item. Found 'http://drupal.org'
So I just added line brakes before each argument of t function at 41 line and followed correct indentation.
Comment #6
volegerUnexpected behavior will appear when function
theme_logo_block_image_style()move into.theme.incfile.That theme function can't be rendered after
logo_block_block_save(). Only after cache rebuild.But leaving
theme_logo_block_image_style()in.modulefile fix that.Comment #7
ordermind commentedThere, now I have applied your patch with some cosmetic changes. A new release is on the way.