This is spun off from #2831936-177: Add "File" MediaSource plugin, quoted here for convenience:

It needs follow-up to discuss the set to add 'odf' and cover with test this defaults

The File media source plugin should probably set up its source field to accept Open Document format(s) like ODF, ODT, and whatever else makes sense. So here is an issue to discuss and implement that :)

Postponed on #2831936: Add "File" MediaSource plugin.

CommentFileSizeAuthor
#5 2884383-5.patch854 byteswim leers
#4 2884383-4.patch836 byteswim leers
#3 2884383-3.patch818 byteswim leers

Comments

phenaproxima created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Postponed » Active

#2831936: Add "File" MediaSource plugin landed!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2884383-3.patch818 bytes

According to https://en.wikipedia.org/wiki/OpenDocument:

The most common filename extensions used for OpenDocument documents are:[11][12]
.odt and .fodt for word processing (text) documents
.ods and .fods for spreadsheets
.odp and .fodp for presentations
.odg and .fodg for graphics
.odf for formulae, mathematical equations

Added all of those.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new 2884383-4.patch836 bytes

Now added support for https://en.wikipedia.org/wiki/IWork: .pages, .numbers and .key.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new 2884383-5.patch854 bytes

And finally, this only supported .doc and .docx. What about .xls + .xlsx and .ppt + .pptx? Added those too.

dinesh18’s picture

dinesh18 commented

It would be great if we could have a configuration section at the back-end, so that according to the need, user can enter different formats.
Correct me if I am wrong.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

That already exists as part of the Field UI :) Although in this case the field is locked to prevent deletion, so I don't know if the user is allowed to change the settings.

In any event, we are aware of that ask and have a follow-up issue opened somewhere in which we will address it :)

dinesh18’s picture

dinesh18 commented

Thanks @phenaproxima.
#5 Looks good to me. +1 to RTBC

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

I agree. Tests have passed, and I personally don't see any reason to add additional test coverage for this. RTBC.

  • catch committed c122124 on 8.4.x 
    Issue #2884383 by Wim Leers: File media source should accept Open...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.4.x, thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

@Dinesh18: we have #806102: Locked fields can change the widget but not settings to figure out how to change settings on a locked field :)

dinesh18’s picture

dinesh18 commented

Thanks @Gábor Hojtsy. I will have a look and try to contribute on it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.