This is spun off from #2831936-176: Add "File" MediaSource plugin, specifically this point of review:

I noticed that the "Media" view is inconsistent with the "Content" and "Files" views:

  1. When no content is available, we don't see the <thead> that those other views do show.
  2. The Media name value is in the middle instead of the very first (leftmost) thing.
  3. The button to apply the exposed filters says Apply instead of Filter
  4. Media: Publishing status, Content: Published status
  5. Provider should be Media source or probably Source

Generally, we should make the "Media" view as consistent with the "Content" view as possible, since that's the canonical/most used one.

Let us address all of problems, here in this issue.

Media BEFORE
Media AFTER
Files
Comments
Content
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

Title: Improve the administrative Media vie » Improve the administrative Media view
Wim Leers’s picture

I wrote that in #2831936-176: Add "File" MediaSource plugin. Adding the screenshots I forgot to add.

Wim Leers’s picture

Status: Active » Needs review
FileSize
5.3 KB

This fixes points 2–5.

Wim Leers’s picture

Issue summary: View changes
FileSize
623 bytes
5.52 KB
121.72 KB

Oh, and by diffing views.view.files and views.view.media, I was able to find the solution for point 1.

Now the Media view looks like this:

Gábor Hojtsy’s picture

Hm, I was surprised the submit button would be labeled Filter and not Apply. We had an issue to change this default in views, but reverted later. But I guess it applies to core views at least. It becomes odd once you have a sort-by form element exposed as well when the things you set are not only filters but also sorts. But core exposed views elements do not include exposed sorts.

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed all the changes and apart from the unfounded concern I had above it looks good :)

  • catch committed 79a8774 on 8.4.x
    Issue #2884379 by Wim Leers, phenaproxima, Gábor Hojtsy: Improve the...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.4.x, thanks!

Do we need test coverage for the admin view - I'm assuming the views config-only patch here means we have zero.

Wim Leers’s picture

Do we need test coverage for the admin view - I'm assuming the views config-only patch here means we have zero.

Indeed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.