Closed (fixed)
Project:
Devel PHP
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
3 Jun 2017 at 18:04 UTC
Updated:
25 Jul 2019 at 12:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
davps commentedThis patch and attached images show how it works.
Comment #3
willzyx commented@thanks for contributing! This could be an useful feature. A quick review:
I think that the coding standard for using this class is use FQNS (\ParseError, \Error - without using the use statement)
there is a reason for catching the two error separately? looking at the Error hierarchy ParseError extends Error.. so probably we can simply write the code like :
I'm missing something?
and probably we need to write a little test for this :)
Comment #4
davps commentedComment #5
moshe weitzman commented[#3005475: Remove Execute PHP feature]
Comment #6
geek-merlinCode moved due to #3005475-15: Remove Execute PHP feature.
Comment #7
davps commentedPatch updated.
Added few tests.
Comment #9
lussolucaCommitted and pushed to 8.x-1.x
Thank you!