Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Apparently PHP 7.1 throws a warning when you try to subtract a string from an integer, and the Statistics module does that during cron runs. Fixing this should take care of all the remaining PHP 7.1 test failures in Drupal 7 core.
This was fixed a long time ago in Drupal 8, as a side effect of #1831522: Convert statistics variables to config/state.
Comment | File | Size | Author |
---|---|---|---|
#2 | statistics-integer-2883202-2.patch | 563 bytes | David_Rothstein |
Comments
Comment #2
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedComment #3
Crell CreditAttribution: Crell at Platform.sh commentedLooks entirely reasonable to me, and testbot agrees.
Comment #4
stefan.r CreditAttribution: stefan.r commentedComment #6
stefan.r CreditAttribution: stefan.r commentedCommitted and pushed to 7.x, thanks!
Comment #7
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedI think it's worth mentioning in the release notes that all tests now pass on PHP 7.1, so I added in to CHANGELOG.txt (not related to this issue specifically, but this happened to be the one that fixed the last remaining failures).