Apparently PHP 7.1 throws a warning when you try to subtract a string from an integer, and the Statistics module does that during cron runs. Fixing this should take care of all the remaining PHP 7.1 test failures in Drupal 7 core.

This was fixed a long time ago in Drupal 8, as a side effect of #1831522: Convert statistics variables to config/state.

CommentFileSizeAuthor
#2 statistics-integer-2883202-2.patch563 bytesDavid_Rothstein

Comments

David_Rothstein created an issue. See original summary.

David_Rothstein’s picture

David_Rothstein commented
Status: Active » Needs review
StatusFileSize
new statistics-integer-2883202-2.patch563 bytes
Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

Looks entirely reasonable to me, and testbot agrees.

stefan.r’s picture

stefan.r commented
Issue tags: +Pending Drupal 7 commit

  • stefan.r committed c9493f5 on 7.x 
    Issue #2883202 by David_Rothstein: Statistics module subtracts an empty...
stefan.r’s picture

stefan.r commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Pending Drupal 7 commit

Committed and pushed to 7.x, thanks!

David_Rothstein’s picture

David_Rothstein commented
Issue tags: +7.55 release notes

I think it's worth mentioning in the release notes that all tests now pass on PHP 7.1, so I added in to CHANGELOG.txt (not related to this issue specifically, but this happened to be the one that fixed the last remaining failures).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.