Problem/Motivation

Paragraph types in paragraphs collection are named quote, link, title,... except container, which is paragraphs_container. We also have a field_link, where other fields are named paragraphs_*

Proposed resolution

Rename those

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Primsi created an issue. See original summary.

primsi’s picture

Assigned: Unassigned » primsi
primsi’s picture

Status: Active » Needs review
StatusFileSize
new5.99 KB
berdir’s picture

What about the paragraphs_container_paragraphs field? Should we rename that here as well while we touch this?

And if so, what name should we use?

primsi’s picture

StatusFileSize
new14.74 KB
new17.67 KB

paragraphs_container?

berdir’s picture

Status: Needs review » Needs work

Nope, I don't think think that makes sense, it is a paragraphs field. It's long/repetitive, but lets keep that then.

However, as discussed, what we should rename is field_link to paragraphs_link as well as removing the intro/footer specific texts in favor of paragraphs_text unless they have conflicting storage settings.

primsi’s picture

Title: Rename paragraphs_container to container » Make field and paragraph types names more consistent
Issue summary: View changes
StatusFileSize
new11.08 KB
new17.07 KB

- renamed field_link to paragraphs_link
- used paragraphs_text for footer and intro

primsi’s picture

Status: Needs work » Needs review
StatusFileSize
new4.65 KB
new15.89 KB

Fixing some unintentional changes.

The last submitted patch, 3: rename-2881617-3.patch, failed testing.

The last submitted patch, 5: rename-2881617-5.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 8: make_field_and-2881617-8.patch, failed testing.

primsi’s picture

Status: Needs work » Needs review
StatusFileSize
new8.94 KB
new24.83 KB

Hm, I thought I did a search/replace on the entire module. Adding changes for _demo.

Status: Needs review » Needs work

The last submitted patch, 12: make_field_and-2881617-12.patch, failed testing.

primsi’s picture

More test fixes.

primsi’s picture

Status: Needs work » Needs review

The last submitted patch, 7: rename-2881617-7.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 14: make_field_and-2881617-14.patch, failed testing.

primsi’s picture

Status: Needs work » Needs review
StatusFileSize
new3.23 KB
new30.19 KB

.... more.

Status: Needs review » Needs work

The last submitted patch, 18: make_field_and-2881617-18.patch, failed testing.

primsi’s picture

Status: Needs work » Needs review
StatusFileSize
new834 bytes
new30.65 KB

Missed one.

pivica’s picture

Nope, I don't think think that makes sense, it is a paragraphs field. It's long/repetitive, but lets keep that then.

Original idea was to have header and footer paragraph types because of style variations - are we going to move this to style plugin then or drop fully?

berdir’s picture

We're not removing the paragraph types, we just unify them so that intro, text and footer all use the same text *field*. That means fewer fields and fewer tables.

pivica’s picture

Cool :)

berdir’s picture

Status: Needs review » Reviewed & tested by the community

Lets do this, seems to be fine.

  • Primsi committed ef8b3ef on 8.x-1.x
    Issue #2881617 by Primsi, Berdir: Make field and paragraph types names...
primsi’s picture

Status: Reviewed & tested by the community » Fixed

Committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.