Closed (fixed)
Project:
Paragraphs Collection
Version:
8.x-1.x-dev
Component:
Fundamental types
Priority:
Major
Category:
Task
Assigned:
Reporter:
Created:
26 May 2017 at 07:01 UTC
Updated:
9 Jun 2017 at 15:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
primsi commentedComment #3
primsi commentedComment #4
berdirWhat about the paragraphs_container_paragraphs field? Should we rename that here as well while we touch this?
And if so, what name should we use?
Comment #5
primsi commentedparagraphs_container?
Comment #6
berdirNope, I don't think think that makes sense, it is a paragraphs field. It's long/repetitive, but lets keep that then.
However, as discussed, what we should rename is field_link to paragraphs_link as well as removing the intro/footer specific texts in favor of paragraphs_text unless they have conflicting storage settings.
Comment #7
primsi commented- renamed field_link to paragraphs_link
- used paragraphs_text for footer and intro
Comment #8
primsi commentedFixing some unintentional changes.
Comment #12
primsi commentedHm, I thought I did a search/replace on the entire module. Adding changes for _demo.
Comment #14
primsi commentedMore test fixes.
Comment #15
primsi commentedComment #18
primsi commented.... more.
Comment #20
primsi commentedMissed one.
Comment #21
pivica commentedOriginal idea was to have header and footer paragraph types because of style variations - are we going to move this to style plugin then or drop fully?
Comment #22
berdirWe're not removing the paragraph types, we just unify them so that intro, text and footer all use the same text *field*. That means fewer fields and fewer tables.
Comment #23
pivica commentedCool :)
Comment #24
berdirLets do this, seems to be fine.
Comment #26
primsi commentedCommitted