I started using the PET module for a project and therefore I fixed a lot of problems and features that were not ported:

  • Back Button in the Preview works now
  • The mails were validated against drupal user IDs
  • Token replacement and token alter function implemented. This gives you the opportunity to alter the substitions
  • fixed some coding issues

If you want to use this module in a productive environment, you will need this patch.

CommentFileSizeAuthor
0001-Several-fixes-to-make-PET-usable.patch7.6 KBayalon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ayalon created an issue. See original summary.

Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer commented

Thanks for the patch, I'll review it and commit if all good.

Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer commented
Status: Needs review » Needs work

The patch failed to apply, can please update your patch,

  1. diff --git a/web/modules/custom/pet/pet.module b/web/modules/custom/pet/pet.module

    You took wrong file path. Please close from project repo. 

  2. +++ b/web/modules/custom/pet/pet.module
@@ -370,13 +367,29 @@ function pet_is_natural($val, $base = 1) {
diff --git a/web/modules/custom/pet/src/Form/PetPreviewForm.php b/web/modules/custom/pet/src/Form/PetPreviewForm.php

    Same here.

  • Sharique committed 0a002e9 on 8.x-1.x 
    Issue #2881124 by ayalon, Sharique: fixed back button on preview and...
Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer commented

@ayalon some of the fixes suggested are already done in dev, I'm picking remaining fixes and committing it.

  • Sharique committed 7e6bb70 on 8.x-1.x 
    Issue #2881124 by ayalon, Sharique: Make Pet preview usable in Drupal 8
Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer commented
Status: Needs work » Fixed

I added remaining parts of patch as well. Thanks @ayalon for your work.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.