Hi, I installed and set up the module with testing links https://vimeo.com/, https://facebook.com/, https://twitter.com/. And I got PHP Notice message for each link:
Notice: Undefined variable: host3 in link_icons_field_formatter_view() (line 193 of /srv/bindings/208dcb82d69646579233540884ac1525/code/sites/all/modules/contrib/link_icons/link_icons.module).

CommentFileSizeAuthor
#2 link_icons-host3_undefined_variable-2881082.patch773 byteslevmyshkin

Comments

levmyshkin created an issue. See original summary.

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
StatusFileSize
new link_icons-host3_undefined_variable-2881082.patch773 bytes

I added additional validation for $host3 variable

natts’s picture

natts
He/they
Primary language English
Location London
commented

Thanks for that, I should have tested this issue.

I'll add a version of your patch in to a new release.

  • natts committed 2598c02 on 7.x-1.x 
    Fixed issue #2881082 by levmyshkin: Notice: Undefined variable: host3 in...
natts’s picture

natts
He/they
Primary language English
Location London
commented
Assigned: Unassigned » natts
Status: Active » Fixed
natts’s picture

natts
He/they
Primary language English
Location London
commented
Status: Fixed » Closed (fixed)