Steps to recreate:
1. Download module on Drupal core 8.3.2 version
2. Turn on Adobe Analytics module
3. Add variables to list and save

Get error in phplog:

Uncaught PHP Exception InvalidArgumentException: "The configuration property extra_variables.0.name doesn't exist." at webroot/core/lib/Drupal/Core/Config/Schema/ArrayElement.php line 74

CommentFileSizeAuthor
#9 2880940-9-adobe_analytics-fix_extra_variables_schema.patch825 bytesjuampynr
#3 2880940-schema-fix-extra_variables-error.patch467 bytesEsmeraldaUBM

Comments

EsmeraldaUBM created an issue. See original summary.

EsmeraldaUBM’s picture

EsmeraldaUBM commented

Sorry so after having looked at this (and researching similar problems) it seems like this might be fixable in the schema by just adding:

.* to end of extra_variables

So the schema would be:

extra_variables.*:

does this seem correct?

EsmeraldaUBM’s picture

EsmeraldaUBM commented
StatusFileSize
new 2880940-schema-fix-extra_variables-error.patch467 bytes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review

Don't forget to set the issue status to "needs review" when you upload a patch, it helps others know there's something to look at. Thanks!

EsmeraldaUBM’s picture

EsmeraldaUBM commented

Sorry about that thanks! :)

kmoll’s picture

kmoll commented

I will review this at the code sprint at Drupacon Vienna this week.

kmoll’s picture

kmoll commented
Assigned: Unassigned » kmoll
juampynr’s picture

juampynr commented
Status: Needs review » Reviewed & tested by the community

Works for me.

juampynr’s picture

juampynr commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2880940-9-adobe_analytics-fix_extra_variables_schema.patch825 bytes

Actually, when I started working on the module's tests I discovered that the configuration schema is broken. Here is a patch that fixes it.

kmoll’s picture

kmoll commented

Thanks, @juampynr, I just circled back around to this. I tested your patch and can confirm its working and fixed the issue. I like declaring the config objects better than just adding the .* to the config element. I will commit shortly. Thanks!

kmoll’s picture

kmoll commented

  • kmoll committed 510c412 on 8.x-1.x authored by juampynr 
    Issue #2880940 by EsmeraldaUBM, juampynr, kmoll: Error: Configuration...
kmoll’s picture

kmoll commented

Change has been committed, I will cut a new alpha2 tag with the change shortly to make it easier to be fetched by composer.

kmoll’s picture

kmoll commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.