Thank you for this nice module.

When using this module on a site with the interface language other than English, I found I couldn't delete permissions backups with the bulk operation interface (admin/people/permissions/backup_permissions).

Probably it's caused by the lines like:

  if ($form_state['values']['op'] == 'Update') {

As for the fix, it may be OK to just wrap the 'Update' with t() but I believe it's better to use $form_state['triggering_element']['#name'].

CommentFileSizeAuthor
#2 backup_permissions-support_other_language-2880491-2.patch1.54 KBhgoto

Comments

hgoto created an issue. See original summary.

hgoto’s picture

hgoto commented
Status: Active » Needs review
StatusFileSize
new backup_permissions-support_other_language-2880491-2.patch1.54 KB

Here is a patch. This uses $form_state['triggering_element']['#name'] instead of $form_state['values']['op'].

jim.applebee’s picture

jim.applebee commented
Status: Needs review » Fixed
jim.applebee’s picture

jim.applebee commented
Status: Fixed » Closed (fixed)