When attempting to enable Web Profiler sub module of devel.

CommentFileSizeAuthor
#3 config_split-drupal_console_support-2878969-3.patch1.25 KBsinn
#2 trait_not_found-2878969-2.patch1.12 KBznak

Comments

realityloop created an issue. See original summary.

znak’s picture

znak commented
Status: Active » Needs review
StatusFileSize
new trait_not_found-2878969-2.patch1.12 KB

Please, check up.

sinn’s picture

sinn commented
StatusFileSize
new config_split-drupal_console_support-2878969-3.patch1.25 KB

drupal/console and drupal/console-core changed class structure. Tested with drupal/console v1.0.0-rc11 and drupal/console-core v1.0.0-rc8

Status: Needs review » Needs work

The last submitted patch, 3: config_split-drupal_console_support-2878969-3.patch, failed testing.

jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin, Texas
commented
Status: Needs work » Postponed (maintainer needs more info)

I have found that no patch is required when using drupal/console v.1.0.0-rc20

Can anyone else verify?

kmajzlik’s picture

kmajzlik commented

This is not solution. I am not able to enable both config_split and webprofiler together on project which is not using Console (and Console is now incompatible with Drupal 8.4.x-dev)

bircher’s picture

bircher
Location 🇨🇿
commented

Hmm, so any project that has an "optional" console integration is bound to fail when using webprofiler and not using console?
This is not acceptable for me.

I think we need to move the console commands to an optional sub-module.

realityloop’s picture

realityloop commented
Status: Postponed (maintainer needs more info) » Active

  • bircher committed 9416aa3 on 8.x-1.x 
    Issue #2878969 by Znak, sinn: Fatal error: Trait 'Drupal\Console\Core\...
  • bircher committed d0ecc44 on 8.x-1.x
    Issue #2878969 by bircher: Refactor cli integration.
bircher’s picture

bircher
Location 🇨🇿
commented
Status: Active » Fixed

I re-wrote the whole cli integration, so now this is fixed and the future drush and drupal console integration will be more straight forward.
Thanks for the contribution.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.