Follow-up to #2815077: Adopt airbnb javascript style guide v14.1 as new baseline javascript coding standards for Drupal 8 core and contrib

Problem/Motivation

Our versions of the AirBnB JavaScript coding standards are out of date and should be updated.

Proposed resolution

Update versions of our coding standards dependencies.

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

drpal created an issue. See original summary.

dawehner’s picture

Thank you @drpal!

mpdonadio’s picture

+++ b/core/package.json
@@ -14,10 +14,10 @@
-    "eslint-plugin-jsx-a11y": "4.0.0",
-    "eslint-plugin-react": "6.10.3",
+    "eslint-plugin-jsx-a11y": "5.0.1",
+    "eslint-plugin-react": "7.0.1",

IS mentions AirBnB JavaScript coding standards, but these two aren't part of those, correct? Maybe this just needs an IS update to "bump all of things for 8.4 since the other issue sat for a while".

I think a larger question is what the policy will be for keeping these up to date. Keeping in line with other things would be to bump near the beginning of the dev cycle and then keep stable so people don't have a moving target.

Probably also want to update the CR to match the final version of this patch so it will be accurate for 8.4.0.

drpal’s picture

@mpdonadio

Both eslint-plugin-jsx-a11y and eslint-plugin-react are dependencies so they need to be updated as well. I'm sure we'll do this again as we get closer to 8.4 so I'll update the change record once this goes in along with a final update before 8.4.

dawehner’s picture

Maybe a really naive question: What is the reason we don't use something like ^5.0.0 in our package.json files? We still have the yarn lock file, so its actually locked. In the composer.json we actually run with them.

droplet’s picture

@dawehner,

We can do it now. It was no lock file & Yarn. But with lock file now, do it or not seems no much diff :)

+++ b/core/package.json
@@ -14,10 +14,10 @@
+    "eslint-config-airbnb": "15.0.0",

this is updated again with docs & version fixes. We can wait for one more week to see if there's any upstream quick fix on this new release.

drpal’s picture

- Updating eslint, eslint-config-airbnb, eslint-plugin-import, eslint-plugin-jsx-a11y, and eslint-plugin-react to their most recent versions.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.