A couple themers have told me that the pagers do not belong in the last row of tables. Here is a big patch to move them all.

CommentFileSizeAuthor
#6 comment.module_14.diff1.12 KBdrumm
pagers.patch10.87 KBdrumm

Comments

factoryjoe’s picture

factoryjoe commented

This is a good idea because tables should only contain related data. Pagers are not part of the data set and therefore belong *outside* the table.

Additionally, if marked up correctly with thead and tfoot, printing the page will result in headers and footers being repeated on each page. With the footer, this feature would be very confusing.

There may be accessibility issues as well related to the non-semantic placement of the pager, but I'm not an expert on such issues.

dries’s picture

dries commented

If no one objects, I'll commit this patch in the next day or two. When so, this information must be added to a UI guidelines document.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Reviewed & tested by the community

Setting the status. I haven't noticed any conflicting patches happen, so I assume this still applies.

dries’s picture

dries commented

You missed a pager in the comment.module.

Can you update the coding guidelines?

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

Committed to HEAD. Comment.module needs some work. Thanks, Neil.

drumm’s picture

drumm
he/him
Location NY, US
commented
Component: other » comment.module
Status: Needs work » Needs review
StatusFileSize
new comment.module_14.diff1.12 KB

Here is a patch for the comment module.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to HEAD.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)