Getting called a lot on production site and causing slow downs.

CommentFileSizeAuthor
#8 cached_permission.patch5.75 KBvisabhishek
#8 User-2-Patched.png115.7 KBvisabhishek
#8 User-1-patched.png119.25 KBvisabhishek
#8 user2.png112.97 KBvisabhishek
#8 user1.png114.76 KBvisabhishek
#6 add_static_cache_to-2878389-6.patch1.03 KBchop
#5 bypass-gnode-view-access.patch746 bytesrealityloop
#4 add_static_cache_to-2878389-4.patch1018 bytesgro
#3 add-static-cache-gnode_node_grants-2878389-3.patch1021 bytesrealityloop
#2 add-static-cache-gnode_node_grants-2878389-2.patch1020 bytesrealityloop

Comments

realityloop created an issue. See original summary.

realityloop’s picture

realityloop commented
StatusFileSize
new add-static-cache-gnode_node_grants-2878389-2.patch1020 bytes

Not taking credit for this, posting here from a github gist.

realityloop’s picture

realityloop commented
StatusFileSize
new add-static-cache-gnode_node_grants-2878389-3.patch1021 bytes
gro’s picture

gro commented
StatusFileSize
new add_static_cache_to-2878389-4.patch1018 bytes

Updates variable assignment of drupal_static to use pass by reference.

realityloop’s picture

realityloop commented
StatusFileSize
new bypass-gnode-view-access.patch746 bytes

This patch is just to mitigate some of these performance issues (you probably don't want to use it yourself).

chop’s picture

chop commented
Status: Active » Needs review
StatusFileSize
new add_static_cache_to-2878389-6.patch1.03 KB

Motivation for this patch is solid. Re-rolling against the latest 8.x-1.x branch to work with latest rc2.

It may be that some of the performance issues are mitigated by Node Grants changes for anonymous visitors.

chop’s picture

chop commented

Hiding this patch to bypass View Access checks now that Group Node has addressed performance issues with anonymous visitors and access checks.

See commit 11ef18a09c7d2c220a10a485802ffec155068a7e

visabhishek’s picture

visabhishek commented
StatusFileSize
new user1.png114.76 KB
new user2.png112.97 KB
new User-1-patched.png119.25 KB
new User-2-Patched.png115.7 KB
new cached_permission.patch5.75 KB

Still, I am facing the performance issue based on the number of group membership, I want to share some statistic based on my test.

  1. Module Used Group:8.x-1.x-dev
  2. I have created 3 Type of group with relevant permission, which was Open, Moderate and Private.
  3. I have a total of 40 groups with a combination of Open, Moderate and Private group type.
  4. User1 has the membership for all 40 groups
  5. User2 has the membership for 6 group only


Now I am trying to access the same group content list page (group/1/content/) from both users with apache benchmark and result are as follow

User1
User1 Data

User2
User2 Data

I am trying to cache "gnode_node_grants" permission strings based on user and result is very exciting.

User1
Patched user1

User2
Patched user2

I am attaching initial patch where I am trying to cache the permissions to check " is I am on right path ?". ( Right now I am not invalidating the cache we can discuss latter for this)

Status: Needs review » Needs work

The last submitted patch, 8: cached_permission.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

idebr’s picture

idebr commented

Closed #3024031: Performance of gnode_node_grants as a duplicate issue.

jayelless’s picture

jayelless commented

What is the current status of this issue? Now that RC3 with the re-factored caching is out, should this issue be closed ad "fixed"?

jayelless’s picture

jayelless commented
Status: Needs work » Closed (duplicate)
Related issues: +#3029849: Statically cache gnode_node_grants()

Refer #3029849: Statically cache gnode_node_grants(), which is a duplicate.