Problem/Motivation

ManageDisplayTest->testViewModeLocalTasks() tests only for non-existence of Full content link. The test can't realy fail because local tasks block is not placed.

CommentFileSizeAuthor
#3 drupal-local-tasks-test-2878369-1.patch1.28 KBmfernea

Comments

mfernea created an issue. See original summary.

mfernea’s picture

mfernea commented
Status: Active » Needs review

Here is the patch.

mfernea’s picture

mfernea commented
StatusFileSize
new drupal-local-tasks-test-2878369-1.patch1.28 KB

As in here :)

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Haha, negative tests, yes, they do have a problem conceptually

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed fece391 and pushed to 8.4.x. Thanks!
Committed d7aaace and pushed to 8.3.x. Thanks!

Drupal test run
---------------

Tests to be run:
  - \Drupal\field_ui\Tests\ManageDisplayTest::testViewModeLocalTasks

Test run started:
  Wednesday, May 17, 2017 - 00:23

Test summary
------------

\Drupal\field_ui\Tests\ManageDisplayTest::testViewModeLocalT  16 passes   2 fails

If i remove the block placement the test now fails. Nice spot @mfernea!

  • alexpott committed fece391 on 8.4.x 
    Issue #2878369 by mfernea: Tests for local tasks in Manage Display are...

  • alexpott committed d7aaace on 8.3.x 
    Issue #2878369 by mfernea: Tests for local tasks in Manage Display are...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.