Validation for node count 0 for a "FROM" content type. The form goes to next step even if node count for a content type selected in 'From Content Type" field is zero.

CommentFileSizeAuthor
#5 2878178-2.patch743 byteslomasr
#2 2874448-2.patch1.49 KBlomasr

Comments

lomasr created an issue. See original summary.

lomasr’s picture

lomasr commented
StatusFileSize
new 2874448-2.patch1.49 KB

Adding a patch for the issue. Please review.

lomasr’s picture

lomasr commented
Status: Active » Needs review
el1_1el’s picture

el1_1el commented
Status: Needs review » Postponed (maintainer needs more info)

This is the same patch you filed to add help text and module description. Please add patch that actually fixes the issue described

lomasr’s picture

lomasr commented
StatusFileSize
new 2878178-2.patch743 bytes

My bad, sorry about that. Please review the new patch.

lomasr’s picture

lomasr commented
Status: Postponed (maintainer needs more info) » Needs review

  • lomasr authored 6dca43b on 8.x-1.x 
    Issue #2878178 by lomasr: Validation for node count 0 for a "FROM"...
el1_1el’s picture

el1_1el commented
Status: Needs review » Fixed

Thanks!

el1_1el’s picture

el1_1el commented

This validation was removed because it did not take form steps into account and broke functionality

lomasr’s picture

lomasr commented

Please send error screenshot, let me look into it to fix it.

el1_1el’s picture

el1_1el commented

There's no error. It just doesnt validate on the later steps and so the final process doesnt run

el1_1el’s picture

el1_1el commented

I went ahead and fixed this. See commit b764599 for reference.

lomasr’s picture

lomasr commented

Thanks a lot for that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.