A summary of Crell's diatribe.

https://events.drupal.org/file/drupalcon-barcelona-2015-drupal-2020

We need to refactor global variables, render contexts and request stack objects, to give us a flexibility
to rewrite decoupled components in ways to suit ReactPHP, Icicle or whatever we choose for non-blocking code refactoring.

So I want to move this global variable into config.

$_SESSION['dblog_overview_filter']

CommentFileSizeAuthor
#2 global-2877985-2.patch5.62 KBmartin107

Comments

martin107 created an issue. See original summary.

martin107’s picture

martin107 commented
Assigned: martin107 » Unassigned
Status: Active » Needs review
StatusFileSize
new global-2877985-2.patch5.62 KB

Here is the patch.

Everything looks ok when I manually test 'admin/reports/dblog'.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Needs review » Needs work

I didn't review in depth the patch yet, just applied and played with it. Have you tried to use two different users for this? At first glance seems the filters defined by one user affect the view of other users.

Rather than doing this, I honestly prefer to remove the use of $_SESSION entirely. This functionality will be provided already when #2015149: Replace dblog recent log entries with a view be finished.

martin107’s picture

martin107 commented
Status: Needs work » Closed (won't fix)

Rather than doing this, I honestly prefer to remove the use of $_SESSION entirely.

Good point... I will follow that issue .. help out where I can .

Closed ( There is a better way )