Closed (fixed)
Project:
Context
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
10 May 2017 at 14:57 UTC
Updated:
15 Sep 2017 at 12:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
rjjakes commentedUpdated patch credit.
Comment #3
alecsmrekar commentedSeems to work fine.
Comment #4
boshtian commentedThe patch works, but I would further discuss the functionality.
If I would be editing context, I'm not sure that I want to be redirected back to the context list by default.
What I suggest is to add two separate submit actions, with 'Save and continue' and 'Save and exit' labels. The button should look like a "dropbutton", the one Drupal 8 is using on creating node (Save and publish, Save as unpublished).
Comment #5
maaty388 commentedI made changes based on the previous patch. Now we have 2 submit buttons grouped together in one "drop-down button", one is named "Save and exit", which saves entity and redirect to the collection route. Another one is named "Save and continue", which just saves the entity.
Comment #6
maaty388 commentedI just removed weight for save buttons and changed "Save and Continue" to "Save and continue".
Comment #7
icurk commentedNice patch. I think that #6 patch solution is better than #2. It would be nice if on save we show a message to a user that a context was saved. So basically just merge #6 and #2 patch.
Comment #8
maaty388 commentedMerged #6 and #2 together so now it also displays status message
Comment #9
maaty388 commentedComment #10
maaty388 commentedFixed patch because I edited patch instead of code (removed comment)
Comment #11
boshtian commentedIt looks good now. Thank you all for the contribution.
Comment #13
boshtian commented