Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.When trying to edit (clicking on an image) images I get a resulting javascript error when using the latest Chrome v58.
Failed to execute 'setBaseAndExtent' on 'Selection': There is no child at offset 1.
After investigating, it looks to be the same issue some Wordpress Users are having https://github.com/tinymce/tinymce/issues/3611 and looks to be fixed in version 4.5.4 https://www.tinymce.com/docs/changelog/#version456-march302017
The workaround at the time seems to be to use another browser, but who want's to do that ;)
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | panopoly-unpin-chrome-2876031-7.patch | 498 bytes | dsnopek |
| #6 | panopoly_wysiwyg-tinymce-chrome58-fix-2876031-6.patch | 714 bytes | dsnopek |
Comments
Comment #2
NicholasSFound the specific commit in TinyMCE where this issue was patched. https://github.com/tinymce/tinymce/commit/3d03c182bc48982a206283a9f40d0f8c1d3164e1 but since this is fixed in tiny 4.5.x it's not exactly a 1-1 match.
Comment #3
dsnopekHere's some patches for testing. One is against the WYSIWYG module to force it to use the non-minified version of TinyMCE, and the other is for TinyMCE.
These patches work for me, but we'll need to figure out how to get them into Panopoly.
We need to get a better TinyMCE patch that modifies the minified source code to really use this, although, I worry that'll include the full TinyMCE source code if it's minified to one line :-/
Comment #4
dsnopekI forgot to say above:
Thanks, @NicholasS, for finding this bug and tracking down the commit that fixed it for TinyMCE 4! Without that PR, I couldn't have made my patches :-)
Comment #5
dsnopekOk, here's a new TinyMCE patch which doesn't need the WYSIWYG patch. I'll follow-up with a .make file patch next, and we can try unpinning Chrome 57 on Travis (per #2869464: All Chrome tests failing with "Could not open connection: An unknown server-side error") and see if the tests pass
Comment #6
dsnopekHere's the panopoly_wysiwyg patch
EDIT: Here's a build on Travis with Chrome 58 https://travis-ci.org/dsnopek/panopoly/builds/230887986
Comment #7
dsnopekHere's the patch to the main repo to unpin Chrome
Comment #8
cboyden CreditAttribution: cboyden commentedI've tested this with Chrome 58 on our child distro, both on Travis and manually, and it's working great.
Comment #10
dsnopekCommitted. Thanks, Everyone!
Comment #13
dsnopekFor lack of a better place to put it, here's an updated patch for this issue against TinyMCE 3.5.12