Drupal 7.x: Ajax support / Use behaviors for 2.x

this patch work correctly with the module Asaf in D7
https://www.drupal.org/project/asaf

Thanks
Edit: My error, only works on first ajax load

new patch to reload recaptcha in all ajax calls

This shouldn't have been marked as a duplicate, since the referenced parent issue is for the 8.x branch. If someone can find a duplicate 7.x issue and link it here then feel free to close again.

What I would say about the patch is that it still throws an 'Undefined method' error on first page load. It should also be checking for the existence of grecaptcha.render in case everything has not fully initialised at the time of load.

It works great for ajax requests though.

@mattjones86: it's common to fix issues in one branch and then mark the issue as needs porting to the other branch, which I guess is what hass was doing. If this is going to be open separately, it seems worthwhile to make it really clear from the title that it's 90% the same, just for a different branch.

FYI: There's also a patch for this in #2493183-153: Ajax support / Use behaviors which works well.
It's also using #attached which is preferred over calling drupal_add_js().

#6 worked well here

deleted

Here the fixed patch from #12 to apply it within the module directory.

Patch #13 work for me.

I'm going to mark this back as needing review, and take a patch from the corresponding D8 issue to move this one along, specifically I'm working from #2493183-168: Ajax support / Use behaviors.
I've fixed the broken test from that patch, and put back the defer attribute on the script that that patch removed, the only other real change is that the tag is going to lose the async attribute, but I've included support for that once #1664602: Allow attributes to be passed to drupal_add_[css|js] (SRI) lands.

This patch is superior to the one in #13 here because:

• The external recaptcha script is also added to the page on an AJAX request.
• It uses the recaptcha methods to reset recaptcha if it's been initialized on an element, rather than simply blatting the DOM.

Doh! Copy/paste fail there.

I’ve had a look at the code and think that the overall approach looks good. There are a few code-style issues there though. Although the existing recaptcha isn’t exactly coding-style compliant at least new code should be.

I’m also marking the core issue as related.

Could you be more specific about what the code style issues that you're referring to are please?

Could you be more specific about what the code style issues that you're referring to are please?

Sorry, for the vague comment. Here are is the relevant output of phpcs (based on the current 7.x-2.x):

FILE: /home/roman/code/drupal/recaptcha/recaptcha.module
---------------------------------------------------------------------------------------------------------------------------------------------
 135 | ERROR   | [ ] The array declaration extends to column 181 (the limit is 80). The array content should be split up over multiple lines
 135 | ERROR   | [ ] The array declaration extends to column 160 (the limit is 80). The array content should be split up over multiple lines
 139 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters


FILE: /home/roman/code/drupal/recaptcha/recaptcha.test
---------------------------------------------------------------------------------------------------------------------------------------------
 134 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 135 | WARNING | [ ] Line exceeds 80 characters; contains 290 characters
 135 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 147 | ERROR   | [x] There should be no white space after an opening "("
 149 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 150 | WARNING | [ ] Line exceeds 80 characters; contains 296 characters
 150 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses

For the commented out lines I would either ignore it or use /* … */ to silence phpcs.

The patch in #15 does not work for me.

In my use-case we have recaptcha set up as a fallback for recaptcha_v3.

When we fallback to the 'I'm not a robot' checkbox, we tick the box and then we get the loading spinner in the element, but it doesn't verify us.

The patch in #13 does work OK in our use-case.

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.