The location phone submodule does not have a README.

According to Drupal standards, modules should include a useful README.file.
https://www.drupal.org/docs/develop/documenting-your-project/module-docu....

README to follow. Thanks!

CommentFileSizeAuthor
#7 interdiff-2875466-4-7.txt1.5 KBvolkswagenchick
#7 location_phone-add-readme-file-2875466-7.patch1.82 KBvolkswagenchick
#4 interdiff-2859294-2-3.txt3.2 KBvolkswagenchick
#4 location_phone-add-readme-2875466-4.patch1.82 KBvolkswagenchick
#2 location_phone-add-readme-2875466-2.patch1.92 KBvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
StatusFileSize
new location_phone-add-readme-2875466-2.patch1.92 KB

I have uploaded a patch including a useful README for the location_phone submodule. Thanks!

loopduplicate’s picture

loopduplicate commented
Status: Needs work » Needs review
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
StatusFileSize
new location_phone-add-readme-2875466-4.patch1.82 KB
new interdiff-2859294-2-3.txt3.2 KB

I reviewed the patch and found some spacing issues. I fixed this and made some of the copy a little more readable.
I uploaded a patch and an interdiff with the changes. Thanks!

loopduplicate’s picture

loopduplicate commented

The interdiff doesn't match the changes. Not sure what happened there. As far as the patch goes, there's just one thing I see.

+++ b/contrib/location_phone/README.txt
@@ -0,0 +1,60 @@
+(https://www.drupal.org/project/location)package, allows users to set collection

location)package

needs a space

loopduplicate’s picture

loopduplicate commented 
+++ b/contrib/location_phone/README.txt
@@ -0,0 +1,60 @@
+A phone number field is now available for configuration on
+node type administration pages, the user settings page, CCK location field

Just a nitpick, but looks like the first line has a line break too early.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
StatusFileSize
new location_phone-add-readme-file-2875466-7.patch1.82 KB
new interdiff-2875466-4-7.txt1.5 KB

Thanks! I made those changes and uploaded a new patch and an interdiff!

gg24’s picture

gg24 commented
Assigned: volkswagenchick » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good to me. Issuing RTBC.

Thanks!