Problem/Motivation

Create Progress paragraph type based on Bootstrap framework component.
Bootstrap documentation: https://v4-alpha.getbootstrap.com/components/progress/

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#21 progress_paragraph-2875260-21.patch36.23 KBCTaPByK
#21 iterdiff-20-21.txt1.37 KBCTaPByK
#20 progress_paragraph-2875260-20.patch30.19 KBCTaPByK
#19 Screen Shot 2017-06-30 at 11.01.52 AM.png32.63 KBCTaPByK
#19 progress_paragraph-2875260-19.patch40.42 KBCTaPByK
#18 progress_paragraph-2875260-18.patch40.24 KBCTaPByK
#18 interdiff-17-18.txt4.92 KBCTaPByK
#17 progress_paragraph-2875260-17.patch39.56 KBCTaPByK
#15 progress_paragraph-2875260-15.patch39.56 KBacaljuba
#13 progress_paragraph-2875260-13.patch40.05 KBCTaPByK
#13 interdiff-10-13.txt4.63 KBCTaPByK
#10 progress_paragraph-2875260-10.patch39.85 KBCTaPByK
#10 interdiff-8-10.txt2.25 KBCTaPByK
#8 progress_paragraph-2875260-8.patch39.56 KBCTaPByK
#8 interdif-6-8.txt1.25 KBCTaPByK
#6 progress_paragraph-2875260-6.patch39.52 KBCTaPByK
#6 interdif-5-6.txt14.53 KBCTaPByK
#5 progress_paragraph-2875260-5.patch25.76 KBCTaPByK
#4 Screen Shot 2017-05-24 at 3.34.33 PM.png26.01 KBCTaPByK
#4 progress_paragraph-2875260-4.patch18.99 KBCTaPByK

Comments

CTaPByK created an issue. See original summary.

CTaPByK’s picture

CTaPByK commented
Assigned: Unassigned » CTaPByK
CTaPByK’s picture

CTaPByK commented
Title: Progress paragraph type » Progress paragraph plugin and type
CTaPByK’s picture

CTaPByK commented
Status: Active » Needs review
StatusFileSize
new progress_paragraph-2875260-4.patch18.99 KB
new Screen Shot 2017-05-24 at 3.34.33 PM.png26.01 KB

Initial patch covers progress paragraph type an progress bar behavior plugin. Test is needed.

CTaPByK’s picture

CTaPByK commented
StatusFileSize
new progress_paragraph-2875260-5.patch25.76 KB

Updated with simple test coverage, also with base class for javascript tests, and module info file is changed a bit to follow drupal coding standards.

CTaPByK’s picture

CTaPByK commented
StatusFileSize
new interdif-5-6.txt14.53 KB
new progress_paragraph-2875260-6.patch39.52 KB

Patch with demo sub module. Content for progress is created and test for demo content is done.

Status: Needs review » Needs work

The last submitted patch, 6: progress_paragraph-2875260-6.patch, failed testing.

CTaPByK’s picture

CTaPByK commented
Status: Needs work » Needs review
StatusFileSize
new interdif-6-8.txt1.25 KB
new progress_paragraph-2875260-8.patch39.56 KB

Oh, i play a bit with content creation and i was forgot to update test. Here is new patch.

thenchev’s picture

thenchev commented
Status: Needs review » Needs work

width and height are fields that we use in the plugin, if we delete them there is a fatal error. I guess ether we need to handle that somehow

CTaPByK’s picture

CTaPByK commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-8-10.txt2.25 KB
new progress_paragraph-2875260-10.patch39.85 KB

Yes, good catch! Updated. We must keep in mind that some user can delete fields from default paragraph types. Also follow-up for updating BS Bootstrap theme is created https://www.drupal.org/node/2882813.

CTaPByK’s picture

CTaPByK commented
Assigned: CTaPByK » Unassigned
thenchev’s picture

thenchev commented
Status: Needs review » Needs work 
  1. +++ b/modules/paragraphs_collection_bootstrap_demo/src/Tests/ParagraphsCollectionBootstrapDemoTest.php
@@ -0,0 +1,43 @@
+class ParagraphsCollectionBootstrapDemoTest extends WebTestBase {

    Apparently functional tests are now the preferred way of testing the UI. We should use BrowserTestBase 

  2. +++ b/tests/src/FunctionalJavascript/ParagraphsBootstrapJavascriptTestBase.php
@@ -0,0 +1,86 @@
+ *
+ * @group paragraphs_collection_bootstrap
+ */

    As far as i can tell other base classes for tests don't add this part. Might be wrong but we should try without

CTaPByK’s picture

CTaPByK commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-10-13.txt4.63 KB
new progress_paragraph-2875260-13.patch40.05 KB

Yes i agree with 1. and 2. Updated.

thenchev’s picture

thenchev commented
Status: Needs review » Reviewed & tested by the community

No more complains. Would be great to get this in since we have the demo module in here and some base classes. After that other patches will need to be updated.

acaljuba’s picture

acaljuba commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new progress_paragraph-2875260-15.patch39.56 KB

Now that the demo module skeleton have been commited, we need to change this as well.

thenchev’s picture

thenchev commented
Status: Needs review » Reviewed & tested by the community

Back to rtbc

CTaPByK’s picture

CTaPByK commented
StatusFileSize
new progress_paragraph-2875260-17.patch39.56 KB

Fix test fails.

CTaPByK’s picture

CTaPByK commented
StatusFileSize
new interdiff-17-18.txt4.92 KB
new progress_paragraph-2875260-18.patch40.24 KB
CTaPByK’s picture

CTaPByK commented
StatusFileSize
new progress_paragraph-2875260-19.patch40.42 KB
new Screen Shot 2017-06-30 at 11.01.52 AM.png32.63 KB

CTaPByK’s picture

CTaPByK commented
StatusFileSize
new progress_paragraph-2875260-20.patch30.19 KB

Re-roll.

CTaPByK’s picture

CTaPByK commented
StatusFileSize
new iterdiff-20-21.txt1.37 KB
new progress_paragraph-2875260-21.patch36.23 KB
CTaPByK’s picture

CTaPByK commented

Follow-up created: https://www.drupal.org/node/2893546

  • Denchev authored a19ebe0 on 8.x-1.x 
    Issue #2875260 by CTaPByK, acaljuba, Denchev: Progress paragraph plugin...
thenchev’s picture

thenchev commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.