CommentFileSizeAuthor
#8 add_change_record_to-2873798-8.patch1.2 KBpk188
#4 add_change_record_to-2873798-3.patch16.43 KBschiavone

Comments

schiavone created an issue. See original summary.

josephcheek’s picture

josephcheek
Location Provo, UT
commented

please fix EntityManagerInterface.php at the same time

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Title: Add Change record to @deprecated for EntityManager.php » Add Change record to @deprecated for EntityManager
schiavone’s picture

schiavone commented
StatusFileSize
new add_change_record_to-2873798-3.patch16.43 KB

Rolled patch adding change records to deprecated code. Found one function not marked deprecated that is marked in patch and function useCaches which looks like it does not get deprecated. Need to confirm whether useCaches should not be deprecated.

schiavone’s picture

schiavone commented

@josephcheek opened issue to add change record to EntityManagerInterface here https://www.drupal.org/node/2873858

schiavone’s picture

schiavone commented
Status: Active » Needs review
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
Related issues: +#2873858: Add Change record to @deprecated for EntityManagerInterface

Generally, this looks right, but I can't apply it to check.

pk188’s picture

pk188 commented
Status: Needs work » Needs review
StatusFileSize
new add_change_record_to-2873798-8.patch1.2 KB

All the changes already done by some other issue.
I found only 2 changes which i did.
Please check once for it's correctness.

pk188’s picture

pk188 commented
Issue tags: -Needs reroll
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Closed (duplicate)
Related issues: +#2897015: EntityManager class/method @deprecation is incomplete

The deprecation messages were expanded in #2867882: Expand @deprecated docblocks in EntityManager.php so this issue is a duplicate.

Adding a follow-up: #2897015: EntityManager class/method @deprecation is incomplete

@pk118: If you'd like, you could file your patch under the follow-up.