One of the biggest holes in the D6 to D8 migration path is the lack of support for reference fields. It's time to start the process. Rather than try to migrate everything in a single, huge, hard-to-review patch, I'd like to approach things piecemeal.

To that end, let's begin by migrating the field storage definitions for Drupal 6 node reference fields to D8 entity reference fields.

CommentFileSizeAuthor
#13 2872660-12-do-not-test.patch16.7 KBphenaproxima
#12 interdiff-2872660-9-12.txt1.71 KBphenaproxima
#12 2872660-12.patch155.62 KBphenaproxima
#10 2872660-9-do-not-test.patch15.45 KBphenaproxima
#9 interdiff-2872660-7-9.txt4.43 KBphenaproxima
#9 2872660-9.patch154.38 KBphenaproxima
#7 2872660-7.patch150.72 KBphenaproxima
#5 2872660-5.patch149.97 KBphenaproxima
#2 2872660-2.patch150.1 KBphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
StatusFileSize
new 2872660-2.patch150.1 KB

Here's the initial patch, with test coverage.

Status: Needs review » Needs work

The last submitted patch, 2: 2872660-2.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue tags: +Needs reroll

Needs reroll in the wake of #2665196: Migration for email fields is missing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2872660-5.patch149.97 KB

Status: Needs review » Needs work

The last submitted patch, 5: 2872660-5.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: Migrate D6 node reference fields to D8 entity reference field storage config entities » Migrate D6 node reference fields to D8 entity reference field definitions
Status: Needs work » Needs review
StatusFileSize
new 2872660-7.patch150.72 KB

Needed a reroll, apparently, and a little more love to the auxiliary D6 field migrations in order to pass the tests. This is all now done.

Status: Needs review » Needs work

The last submitted patch, 7: 2872660-7.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2872660-9.patch154.38 KB
new interdiff-2872660-7-9.txt4.43 KB

This should fix it! I also added support for migrating the field formatter setttings, plus test coverage of that.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2872660-9-do-not-test.patch15.45 KB

Here's a review-only patch that excludes the fixture changes.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work 
+++ b/core/modules/field/tests/src/Kernel/Migrate/d6/MigrateFieldTest.php
@@ -84,36 +84,41 @@ public function testFields() {
+    // Test a node reference field.
+    $field_storage = FieldStorageConfig::load('node.field_company');
+    $this->assertInstanceOf(FieldStorageConfig::class, $field_storage);
+    $this->assertSame('node', $field_storage->getSetting('target_type'));

This is the ER field tests that I found. I think we should do some type check that the field is an ER field. Thanks for the review only patch. Makes it 10x easier to review.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2872660-12.patch155.62 KB
new interdiff-2872660-9-12.txt1.71 KB

Good call. I have added that, plus some assertions about the field config entity as well.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2872660-12-do-not-test.patch16.7 KB

A review-only patch, to make the committers' lives easier.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Reviewed & tested by the community

Optimistically changing status. Let's hope it comes back green.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Issue tags: +Migrate critical

Reference field migrations are one of the final missing pieces of the complete migration path from D6 and D7. I've discussed with the other Migrate maintainers in IRC and there is consensus that this is Migrate critical.

The last submitted patch, 12: 2872660-12.patch, failed testing.

  • catch committed 5380355 on 8.4.x 
    Issue #2872660 by phenaproxima: Migrate D6 node reference fields to D8...

  • catch committed 0fee31c on 8.3.x 
    Issue #2872660 by phenaproxima: Migrate D6 node reference fields to D8...
catch’s picture

catch
he/him
Primary language English
commented
Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.4.x and cherry-picked to 8.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.