Problem/Motivation
#2841291: Fix NOT NULL handling in the entity storage and 'primary key' changes when updating the storage definition of an identifier field changed the entity storage to be more strict with required entity fields (i.e. mark them as NOT NULL), and this uncovered many problems with the test coverage of the Content Moderation and Workspace modules.
Proposed resolution
Fix the test coverage to properly populate all required fields for the Workflow, ContentModerationState and Workspace entity types.
Remaining tasks
Write a patch.
User interface changes
Nope.
API changes
Nope.
Data model changes
The 'workflow' and 'moderation_state' base fields from ContentModerationState
will be marked as required again.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2871036-show-fails.patch | 1.16 KB | amateescu |
Comments
Comment #2
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedThis patch will show the test fails in Content Moderation, once #2841291: Fix NOT NULL handling in the entity storage and 'primary key' changes when updating the storage definition of an identifier field is committed.
Not marking as needs review for now because we have to wait for that issue to get in.
Comment #3
Wim LeersThis is blocked on #2841291: Fix NOT NULL handling in the entity storage and 'primary key' changes when updating the storage definition of an identifier field.
Comment #6
tstoecklerHope it's fine to expand the scope of this to cover workspace as well, it suffers from the same problem.
Comment #7
tstoeckler