Convert web tests to browser tests for editor module

This is blocked on #2795041: BrowserTestBase: Add drupalPostWithFormat because of EditorSecurityTest test.

Since #2795041: BrowserTestBase: Add drupalPostWithFormat is closed (won't fix) I am switching this back to active.

first roll, just moving stuff around and fixing node element stuff.

This will fail on the ajaxy stuff.

and now rolled against 8.6.x

New patch with changes to work with BrowserTestBase.

Done:
* Fixed all the "ajax/post" calls
* replaced t() with FormattableMarkup() when needed
* few other minor changes

@Tessa Bakker this is looking really good already, just some nits:

1. +++ b/core/modules/editor/tests/src/Functional/QuickEditIntegrationLoadingTest.php
   @@ -1,18 +1,21 @@
   +use Drupal\FunctionalJavascriptTests\JavascriptTestBase;
   

   unused use

2. +++ b/core/modules/editor/tests/src/Functional/QuickEditIntegrationLoadingTest.php
   @@ -1,18 +1,21 @@
   +use GuzzleHttp\Exception\ClientException;
   

   unused use

3. +++ b/core/modules/editor/tests/src/Functional/QuickEditIntegrationLoadingTest.php
   @@ -108,13 +124,30 @@ public function testUserWithPermission() {
   +  protected function getCookies() {
   

   this needs a docblock

4. +++ b/core/modules/editor/tests/src/Functional/EditorSecurityTest.php
   @@ -389,13 +390,18 @@ public function testSwitchingSecurity() {
   +    $domain = parse_url($this->getUrl(), PHP_URL_HOST);
   +    $session_id = $this->getSession()->getCookie($this->getSessionName());
   +    $cookies = CookieJar::fromArray([$this->getSessionName() => $session_id], $domain);
   
   +++ b/core/modules/editor/tests/src/Functional/QuickEditIntegrationLoadingTest.php
   @@ -108,13 +124,30 @@ public function testUserWithPermission() {
   +      'cookies' => $this->getCookies(),
   

   two tests with two different ways of setting the needed cookies, can we do this in one consistent way?

Thanks for the review!

This looks great!

1. +++ b/core/modules/editor/tests/src/Functional/EditorAdminTest.php
   @@ -64,8 +65,8 @@ public function testNoEditorAvailable() {
   -    $this->assertTrue(((string) $options[0]) === 'None', 'Option 1 in the Text Editor select is "None".');
   ...
   +    $this->assertTrue(($options[0]->getText()) === 'None', 'Option 1 in the Text Editor select is "None".');
   

   This is already so much nicer!

2. +++ b/core/modules/editor/tests/src/Functional/EditorSecurityTest.php
   @@ -433,7 +448,21 @@ public function testEditorXssFilterOverride() {
   +  /**
   +   * Get session cookies from current session.
   +   *
   +   * @return \GuzzleHttp\Cookie\CookieJar
   +   *   A cookie jar with the current session.
   +   */
   +  protected function getCookies() {
   +    $domain = parse_url($this->getUrl(), PHP_URL_HOST);
   +    $session_id = $this->getSession()->getCookie($this->getSessionName());
   +    $cookies = CookieJar::fromArray([$this->getSessionName() => $session_id], $domain);
   +
   +    return $cookies;
      }
   

   Should we create a follow up to make this process easier for people? Maybe it would it be worth to moving this to BrowserTestBase?

Yeah this looks great.

Totally agree on the follow up, #2983504: Add a way to easily set the cookies in a request done using the Guzzle client

Crediting reviewers and @michielnugter for the original issue creation / management.

Committed 0b8ffb4 and pushed to 8.6.x. Thanks!