Convert web tests to browser tests for config_translation module

@michielnugter

Just as a general typ, it would be great to explain why things are postponed. This one here for example isn't obvious for me :)

Few fixes

+++ b/core/modules/config_translation/tests/src/Functional/ConfigTranslationOverviewTest.php
@@ -77,9 +77,9 @@ public function testMapperListPage() {
+      $this->assertIdentical(1, count($dropbutton->findAll('xpath', '/*')));

@@ -104,9 +104,9 @@ public function testMapperListPage() {
+        $this->assertIdentical(1, count($dropbutton->findAll('xpath', '/*')));

You could use assertCount here

Rewrote the whole conversion as the above patch was not getting applied.

//Naveen

Do we have any existing follow-up issue where are we adding the helper function drupalPostWithFormat?

1) Drupal\Tests\config_translation\Functional\ConfigTranslationUiTest::testViewsTranslationUI
PHPUnit_Framework_Exception: Fatal error: Call to undefined method Drupal\Tests\config_translation\Functional\ConfigTranslationUiTest::drupalPostWithFormat() in /var/www/html/core/modules/config_translation/tests/src/Functional/ConfigTranslationUiTest.php on line 1146

//Naveen

#14 This patch removed the conversion of the ConfigTranslationUiTest. Updated the issue summary accordingly.

//Naveen

Here we go with fixes

//Naveen

+++ b/core/modules/config_translation/tests/src/Functional/ConfigTranslationOverviewTest.php
@@ -77,10 +77,8 @@ public function testMapperListPage() {
     foreach ($this->cssSelect('ul.dropbutton') as $i => $dropbutton) {
-      $this->assertIdentical(1, $dropbutton->count());
-      foreach ($dropbutton->li as $link) {
-        $this->assertTrue(((string) $link->a === 'Translate') || ((string) $link->a === 'List'));
-      }
+      $this->assertIdentical(1, substr_count($dropbutton->getHtml(), '</li>'));
+      $this->assertTrue(($dropbutton->getText() === 'Translate') || ($dropbutton->getText() === 'List'));
     }

@@ -104,10 +102,8 @@ public function testMapperListPage() {
-        $this->assertIdentical(1, $dropbutton->count());
-        foreach ($dropbutton->li as $link) {
-          $this->assertIdentical('Translate', (string) $link->a);
-        }
+        $this->assertIdentical(1, substr_count($dropbutton->getHtml(), '</li>'));
+        $this->assertIdentical('Translate', $dropbutton->getText());
       }
 

What about using $dropbutton->find('li') instead of testing the HTML directly?

yup we could use that. Accommodated #18

$ ../vendor/bin/phpunit modules/config_translation/tests/src/Functional/ConfigTranslationOverviewTest.php 
PHPUnit 4.8.35 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\config_translation\Functional\ConfigTranslationOverviewTest
...

Time: 11.53 minutes, Memory: 6.00MB

OK (3 tests, 72 assertions)

//Naveen

I like it, thank you @naveenvalecha!

Thanks all, agreed it looks good.