Even more random fails in \Drupal\Tests\outside_in\FunctionalJavascript\OutsideInBlockFormTest

there's a bug taking the test such long execution time. I will split it to a new thread if it needed (but we also need a random test. So I do it here together first to save some testbots resource)

This may not be limited to just outside_in and more frequent that it appears:

https://www.drupal.org/pift-ci-job/650067 (outside_in)

https://www.drupal.org/pift-ci-job/650091 (views)

Raising this to Critical as it appears to be causing testing disruption. We'll see if other RTBC get punted back b/c of this.

It seems it missed click on edit area.

  protected function openBlockForm($block_selector) {
    $this->click($block_selector);
    $this->waitForOffCanvasToOpen();

the edit mode has anime on page reload.

hoping this patch will catch a new failure point

#12 failed as expected. the Setting Tray didn't open correctly.

Trying to see if it's Toolbar flicker problem affected.
Same patch as #12 and adding #2542050: Toolbar implementation creates super annoying re-rendering. patch.

As a new module, Setting Tray needs more work to make it more decoupled I think

I created #2871219: Add checks to make sure animation is done in a JavascriptTestBase test because I really dislike using assertWaitOnAjax() to wait for animation. Not suggesting to postpone a critical on this but we might want to add a follow-up to change it after we decided and committed a better version of the animation wait.

Nice work @droplet!

Review:

1. +++ b/core/modules/outside_in/tests/src/FunctionalJavascript/OutsideInBlockFormTest.php
   @@ -182,6 +182,7 @@ public function providerTestBlocks() {
        $this->pressToolbarEditButton();
   +    $this->assertToolbarIsLoaded();
   
   @@ -190,6 +191,7 @@ protected function enableEditMode() {
        $this->pressToolbarEditButton();
   +    $this->assertToolbarIsLoaded();
   
   @@ -363,18 +376,15 @@ protected function assertEditModeDisabled() {
   -    // Waiting for Toolbar animation.
   -    $this->assertSession()->assertWaitOnAjaxRequest();
   

   Should the assertToolbarIsLoaded() be added to the pressToolbarEditButton() function as a replacement for the old waiting for... WaitOnAjaxRequest call instead of calling manually? This would improve the test code-flow

2. +++ b/core/modules/outside_in/tests/src/FunctionalJavascript/OutsideInBlockFormTest.php
   @@ -207,12 +209,25 @@ protected function assertOffCanvasBlockFormIsValid() {
   +  protected function assertToolbarIsLoaded() {
   

   The method should either add an assertion to make sure it's loaded (don't see how yet) or be renamed to waitForToolbar()

3. +++ b/core/modules/outside_in/tests/src/FunctionalJavascript/OutsideInJavascriptTestBase.php
   @@ -42,7 +42,7 @@ public function enableTheme($theme) {
      protected function waitForOffCanvasToOpen() {
   ...
   +    $this->assertNotEmpty($web_assert->waitForElementVisible('css', '#drupal-offcanvas')) ;
   

   We could say that this method should now contain assert in the name as it now asserts the canvas is visible :)

   However: Do we really need to add the assertion here?

Should the assertToolbarIsLoaded() be added to the pressToolbarEditButton() function as a replacement for the old waiting for... WaitOnAjaxRequest call instead of calling manually? This would improve the test code-flow

Some cases, you won't press the edit button

We could say that this method should now contain assert in the name as it now asserts the canvas is visible :)

However: Do we really need to add the assertion here?

A better deal is throw exception from waitForElementVisible / waitForElement directly. Let code guard our code has no mistakes.

Changes look good, thanks @droplet! I created a follow-up to resolve the @todo: #2872104: Resolve @todo in \Drupal\Tests\outside_in\FunctionalJavascript\OutsideInBlockFormTest.

Unrelated fail, back to rtbc. Anyone know if the migrate fail is known?

#21, that was a fail from a patch that just landed, #2665196: Migration for email fields is missing. And since HEAD is broken with the same fail, I'm sure this will get attention.

Committed/pushed to 8.4.x and cherry-picked to 8.3.x, thanks!

Un-parenting close issues, thanks everyone!

Changing to new settings_tray.module component. @drpal thanks for script help! :)