Problem/Motivation

While we only use GET, POST, PATCH and DELETE for entities, we still support other HTTP methods in ResourceBase. When actually using them in a Rest resource configuration entity, however, configuration schema validation fails.

Proposed resolution

Add configuration schema for less common HTTP methods.

CommentFileSizeAuthor
#2 2869904-2.patch1.13 KBtstoeckler

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Needs review
StatusFileSize
new 2869904-2.patch1.13 KB

Here we go.

I re-orderd the schema so that it matches the ordering in ResourceBase::requestMethods().

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Config schema missing for less common HTTP methods in Rest resources » Config schema missing for less common HTTP methods in REST resources configured using 'method' granularity
Status: Needs review » Reviewed & tested by the community

Great catch, thank you!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed e31a043 to 8.4.x and a816c75 to 8.3.x. Thanks!

I backported this to 8.3.x because missing schema is bug - I don't think need a cache clear for this because it is just missing and if you are using this request methods not having the schema probably won't break anything.

  • alexpott committed e31a043 on 8.4.x 
    Issue #2869904 by tstoeckler: Config schema missing for less common HTTP...

  • alexpott committed a816c75 on 8.3.x 
    Issue #2869904 by tstoeckler: Config schema missing for less common HTTP...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.