Convert module to use short array syntax (new coding standard).

Please wait to commit this until more important issues are committed, which would otherwise need rerolls.

This can now continue again. Retesting.

Rerolling Patch

I had some code style issues (PHP Storm formatted it for me). It looks OK to me now.

1. +++ b/src/Controller/RestUIController.php
   @@ -99,41 +99,46 @@ class RestUIController implements ContainerInjectionInterface {
   -      $list[$status]['#attributes'] = array('class' => array('rest-ui-list-section', $status));
   ...
   +      $list[$status]['#attributes'] = [
   +        'class' => [
   +          'rest-ui-list-section',
   +          $status
   +        ]
   +      ];
   

   I don't see why we'd be reflowing the code too?

2. +++ b/src/Form/RestUIForm.php
   @@ -356,17 +356,20 @@ class RestUIForm extends ConfigFormBase {
   +    foreach ($form_state->getValue([
   +      'wrapper',
   +      'methods'
   +    ]) as $method => $values) {
   

   Same here…

3. +++ b/tests/src/Functional/RestUITest.php
   @@ -24,7 +24,10 @@ class RestUITest extends JavascriptTestBase {
   +    $permissions = [
   +      'administer site configuration',
   +      'administer rest resources'
   +    ];
   

   Here it seems sensible though!

4. +++ b/tests/src/Functional/RestUITest.php
   @@ -46,12 +49,14 @@ class RestUITest extends JavascriptTestBase {
   +    $this->assertSession()
   +      ->fieldExists('wrapper[settings][authentication][cookie]');
   ...
   -    $page->findField('granularity')->selectOption(RestResourceConfigInterface::METHOD_GRANULARITY);
   +    $page->findField('granularity')
   +      ->selectOption(RestResourceConfigInterface::METHOD_GRANULARITY);
   
   @@ -66,7 +71,8 @@ class RestUITest extends JavascriptTestBase {
   -    $page->findField('granularity')->selectOption(RestResourceConfigInterface::RESOURCE_GRANULARITY);
   +    $page->findField('granularity')
   +      ->selectOption(RestResourceConfigInterface::RESOURCE_GRANULARITY);
   

   And here it doesn't…

I'll try to work on the suggested changes by @Wim Leers.

Here I have applied the following:

• Reverted the reflow of some lines of code.
• Fixed a minor indentation issue.

Hope everything is in order.

Thanks 2 all!

@cjgratacos congrats with your first Drupal patch in your first month as a member.

@ clemens.tolboom Thanks, excited to be part of this awesome community