Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
The documentation for Drupal\statistics\StatisticsSettingsForm::__construct() incorrectly says it constructs a Drupal\user\StatisticsSettingsForm object, which is the wrong module namespace.
Proposed resolution
Update core/modules/statistics/src/StatisticsSettingsForm file. The docblock for should say:
Constructs a \Drupal\statistics\StatisticsSettingsForm object.
Remaining tasks
Write a short patch!
User interface changes
None.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | after-apply-patch-2868442-4.png | 35.3 KB | amit.drupal |
| #5 | before-apply-patch-2868442-5.png | 33.06 KB | amit.drupal |
| #3 | wrong_namespace_in-2868442-3.patch | 644 bytes | Ada Hernandez |
Comments
Comment #2
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commentedExpecting a one-line patch, so this is a good issue for a first-time contributor.
Comment #3
Ada Hernandez CreditAttribution: Ada Hernandez at MTech, LLC commented@andrewmacpherson thks, I've fixed the comments
Comment #4
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech commentedComment #5
amit.drupal CreditAttribution: amit.drupal as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedPatch are working fine.
Comment #6
Wim Leers@amit.drupal: such screenshots are not helpful. In fact, they're a distraction, because you have to open them separately. They're a waste of storage space on d.o. Instead of posting screenshots, just post a textual comment.
Also, I strongly suspect this is a way to game the issue credit system. Because you're automatically being credited because you posted files. I've seen you do it in many places, and by inspecting your prior posts, I can see that this is the majority of what you do.
Core committer, please revoke @amit.drupal's issue credit.
Comment #7
alexpottCommitted and pushed b8f16bb to 8.4.x and 77a496d to 8.3.x. Thanks!
Comment #10
amit.drupal CreditAttribution: amit.drupal as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented@Wim Leers
Apologies about that. I am not aware on the drupal.org conventions to post comments / screen-shots.
I will go to the relevant drupal.org Slack channels to get guidance on how to go about resolving core issues.
Comment #11
Wim LeersIt is helpful to post screenshots of how a UI (User Interface) changes. You did that several times in the patch. It's not useful to post screenshots of how code changes. That is all!
Looking forward to your next patches (I see you've created patches in the past!) :)