I tried to use the new quick edit drag&drop image feature in Drupal 8.3.x #2421427: Improve the UX of Quick Editing single-valued image fields but saving the image will not work. User will only see "Saving..." on the quick edit form, see attached image. Also an error is displayed when any other page is loaded:
The focal point field should be in the form "leftoffset,topoffset" where offsets are in percentages. Ex: 25,75.
There is also an error in log:
Symfony\Component\Routing\Exception\InvalidParameterException: Parameter "focal_point_value" for route "focal_point.preview" must match "[^/]++" ("" given) to generate a corresponding URL. in Drupal\Core\Routing\UrlGenerator->doGenerate() (line 202 of /vagrant/drupal/current/web/core/lib/Drupal/Core/Routing/UrlGenerator.php).
Comment | File | Size | Author |
---|---|---|---|
#7 | support_setting_focal-2867953-7.patch | 812 bytes | bleen |
| |||
focal_point_cannot_save.png | 29.94 KB | mErilainen |
Comments
Comment #2
bleen CreditAttribution: bleen commentedI've never really used quick edit ... can you please provide some exact steps to reproduce
Comment #3
mErilainen CreditAttribution: mErilainen at Wunder commentedQuick editing any content with an image field will enable the drag&drop when the image is clicked. User then can drag an image to replace an existing image.
I suppose focal point should not be active when quick editing is enabled, because user would have to click on the image to adjust the focus, which now enables the drag&drop interface.
Comment #4
bleen CreditAttribution: bleen commentedI believe this will be fixed by #2701861: Create focal point specific image field widget which is very close to going in ...
Comment #5
bleen CreditAttribution: bleen commentedGood news: #2701861: Create focal point specific image field widget has been merged in
Bad news: This did not fix the quick edit issue
Good news: I was able to reproduce the issue and I think that Focal point should actually be set-able from quick edit.
I'll see what I can do, but (as always) patches are welcome.
Comment #6
bleen CreditAttribution: bleen commentedI went down quite a few rabbit holes trying to figure out how to support setting focal point in the quickedit form and while I think this would be an awesome feature I think it would be better to (at least) get rid of the error that exists right now and add that feature later...
I think this patch should do it, but it needs more testing
Comment #7
bleen CreditAttribution: bleen commentedOoops .... wrong patch