Since most relations probably won't use extra fields (and you have to install to plugin first to add them anyway), turning the checkbox Use 2-step wizard when creating a new %entity_type entity within a %group_type group off is probably a better default for the majority of the use cases.

CommentFileSizeAuthor
#2 2867858-2.patch479 bytesseanb

Comments

seanB created an issue. See original summary.

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
Status: Active » Needs review
StatusFileSize
new 2867858-2.patch479 bytes

Patch is attached.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

> Since most relations probably won't use extra fields (and you have to install to plugin first to add them anyway)

i don't get what this is. does this still exist?

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented

Yes, the relation between a group and a node is stored in a "group content" entity. These "group content" entities are fieldable and the checkbox Use 2-step wizard when creating a new %entity_type entity within a %group_type group allows you to expose the form for this entity.

My argument would be most cases are not adding extra fields for the group content entity, so enabling the checkbox by default does not make sense.

floydm’s picture

floydm commented
Status: Needs review » Reviewed & tested by the community

Agreed, being able to field and add values on the relationship is extremely powerful but not used in most group content scenarios. It should be an opt-in feature rather than the default behaviour.

I've tested the patch in #2. It works as expected.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented

The initial logic was to ensure data integrity: Rather have it on by default and then disable it than risk not collection precious data. But that was back when plugins could be installed without saving the confirmation page. I guess it makes sense to disable this by default now.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.