Problem/Motivation
Follow-up to #2865971: Use stylelint as opposed to csslint in core. Configure the declaration-block-no-shorthand-property-overrides
to be consistent with https://www.drupal.org/docs/develop/standards/css/css-coding-standards
Proposed resolution
Brief instructions on running stylelint - you'll need npm...
All the commands below take place in DRUPAL_ROOT/core
To install stylelint
npm install
This will install Drupal 8's npm dependencies of which stylelint is one.
To run it on all core css files. Apply this issue's patch and do the following command from DRUPAL_ROOT/core
npm run lint:css
Remaining tasks
User interface changes
None
API changes
None
Comment | File | Size | Author |
---|---|---|---|
#11 | 2866806-11.patch | 2.03 KB | harsha012 |
#9 | 2866806-9.patch | 3.1 KB | harsha012 |
#6 | 2866806-6.patch | 3.13 KB | harsha012 |
#3 | declaration-block-no-shorthand-property-overrides-2866806-3.patch | 3.13 KB | Mukeysh |
Comments
Comment #2
alexpottComment #3
Mukeysh CreditAttribution: Mukeysh as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedAdded patch for this.
Comment #5
joelpittetPatch doesn't apply EDIT:
with fuzz but could use a reroll and there is one more thing that snuck in:Comment #6
harsha012 CreditAttribution: harsha012 as a volunteer and at Red Crackle commentedfixed issue.
Comment #7
joelpittetThis needs a reroll against 8.5.x, I'm still seeing some of the changes in #5 and it won't apply.
Comment #8
joelpittetComment #9
harsha012 CreditAttribution: harsha012 as a volunteer and at Red Crackle commentedfixed the issue.
Comment #10
joelpittetVery close!
This is default so we can just remove the null.
The background-color values should just be removed because it is overwritten by the shorthand after it.
Comment #11
harsha012 CreditAttribution: harsha012 as a volunteer and at Red Crackle commentedfixed as per #10
Comment #12
joelpittetThats the ticket! Thanks @harsha012, @Mukeysh and @alexpott!
Comment #14
alexpottCommitted and pushed 19426fd74a to 8.6.x and 2deb0f1d08 to 8.5.x. Thanks!