Update stylelint rules color-hex-length to be consistent with Drupal's CSS standards

this is default config:
https://github.com/stylelint/stylelint-config-standard/blob/master/index...

Rerolled.

@droplet's patch also fixes #2866802: Update stylelint rule color-hex-length to be consistent with Drupal's CSS standards so rather than separating that work into two patches that will have a lot of conflicts, we took the liberty of closing that issue as a duplicate.

I have no idea what that failure means or how to fix it. Maybe @droplet, who created the patch knows? If someone more knowledgeable could provide guidance that would be appreciated.

\core\modules\color\tests\modules\color_test\themes\color_test_theme\color\color.inc

this file I bet. Needed change to short hex.

@droplet — is there an issue for that that we can link here? Or would it be appropriate to include that change in this issue?

Fix it this issue. We bring in the bug from here.

@droplet i have added my patch please check it is working fine?

@Akshay

Thanks. What did you change? I don't see any changes to color.inc.

Some of the new changes to core introduced a few more of these.

misc/dialog/off-canvas.base.css
 34:15  ✖  Expected "#cccccc" to be "#ccc"   color-hex-length

modules/layout_builder/css/layout-builder.css
 25:54  ✖  Expected "#ffffff" to be "#fff"   color-hex-length
 26:21  ✖  Expected "#cccccc" to be "#ccc"   color-hex-length

themes/stable/css/core/dialog/off-canvas.base.css
 34:15  ✖  Expected "#cccccc" to be "#ccc"   color-hex-length

I have rerolled the patch as per the comment #21 for the Drupal 8.5.x version.

Something went wrong with the patch, that is way to big @arunkumark, it should be around 25k I presume

Likely needs #13 taken into account.

+++ b/core/modules/color/tests/modules/color_test/themes/color_test_theme/color/color.inc
@@ -14,15 +14,15 @@
-        'bg' => '#ff0000',
-        'text' => '#0000ff',
+        'bg' => '#ff0',
+        'text' => '#0ff',

The hex colors are converted to short values incorrectly here.

fixed as per #30

I wonder if we can exclude the color.inc css for this and the test CSS?

Split this into 2, this for length and the second for hex case: #2939940: Update stylelint rules color-hex-case to be consistent with Drupal's CSS standards

Here is an updated patch, for only the length issue.

For testbot & the win!

Ok, so there is a bug on how the color module compares, the values need to be normalized to 6 or 3 for comparison. I went with the longer one because it's easier to test for. There is technically a test for this (because it's failing when we change CSS colors to short).

This may be something I need to split off into an issue that could be backported to 7.x because I'm sure it's the same there.

Postponing on #2940088: Shorthand hex colors in CSS files break color module's comparisons

The postponed patch is committed, I'm retesting #36 and hiding my patches.

This needs a reroll.

re rolled the patch

#45 applied cleanly, lint task passed.

> Drupal@ lint:css /mypath/drupal/core
> stylelint "**/*.css" || exit 0