The adjustments field is unused, we can remove it, along with the related methods and interface.

(We initially thought that taxes & promotions would be added directly to the relevant shipment, but they will be added to the order instead).

CommentFileSizeAuthor
#10 2865542-fix-update-8200.patch553 bytesa.dmitriiev
#4 remove_shipping_adjustments_field-2865542-4.patch6.11 KBvasike
#2 remove_shipping_adjustments_field-2865542-2.patch5.44 KBvasike
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike at Centarro, Actualys commented
Status: Active » Needs review
FileSize
remove_shipping_adjustments_field-2865542-2.patch5.44 KB

here is patch for this.
Are there other changes (related) needed for this issue?

p.s.: btw, isn't a similar issue for Commerce core Order item entity?

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Needs work

We're missing an update hook (hook_update) that will remove the adjustments field on existing sites.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike at Centarro, Actualys commented
Status: Needs work » Needs review
FileSize
remove_shipping_adjustments_field-2865542-4.patch6.11 KB

ofcourse
here is a new patch with the update hook

  • bojanz committed 5d6860e on 8.x-2.x authored by vasike 
    Issue #2865542 by vasike: Remove shipping adjustments
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

Improved the update function and committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

finne’s picture

finne
Primary language Dutch
Location Amsterdam
CreditAttribution: finne at Dx Experts commented

Ha! I have a use case where invoices are sent per shipment, and therefor taxes and promotions need to be calculated per shipment. I think I need shipment adjustments :-)

I might want to use the removed code here.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented

You probably don't.
All you need to do is ensure your taxes and promotions are calculated per order item, and you're good to go. A shipment just bundles order items.

a.dmitriiev’s picture

a.dmitriiev CreditAttribution: a.dmitriiev as a volunteer and at 1xINTERNET commented
FileSize
2865542-fix-update-8200.patch553 bytes

I had really old installation and updating now caused the error because update 8200 doesn't state the name of the field to update. The original patch from #2 and #4 was doing it properly, but commit https://www.drupal.org/commitlog/commit/18412/5d6860ede48a225bf1400882fb... has lost the name.

Attaching the patch here and not in a new issue, because I think nobody else will need such an "old" update.