See #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase)

CommentFileSizeAuthor
#6 2865413-6.patch916 bytesjofitz
#6 interdiff-4-6.txt665 bytesjofitz
#4 2865413-4.patch864 bytesjofitz
#4 interdiff-2-4.txt1009 bytesjofitz
#2 convert_web_tests_to-2865413-2.patch2.24 KBgoz

Comments

GoZ created an issue. See original summary.

goz’s picture

goz commented
Status: Active » Needs review
StatusFileSize
new convert_web_tests_to-2865413-2.patch2.24 KB
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Title: Convert web tests to browser tests for serialization module » Move RegisterSerializationClassesCompilerPassTest.php to correct location
Status: Needs review » Needs work 
  1. index 1dec036..96c0987 100644
--- a/core/modules/serialization/src/Tests/NormalizerTestBase.php

    this is a base class and must not be moved. It is already deprecated. We can just leave it alone. 

  2. +++ b/core/modules/serialization/tests/src/Functional/NormalizerTestBase.php
index 6406bbb..5f18927 100644
--- a/core/modules/serialization/src/Tests/RegisterSerializationClassesCompilerPassTest.php

    lol, this file is in the completely wrong place. This is a unit test, not a functional test, so must be moved to tests/src/Unit. This test was introduced in #1996130: REST views: not adding dependencies on Serializer providers.

So we can repurpose this issue to just move the unit test into the correct location.

jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2-4.txt1009 bytes
new 2865413-4.patch864 bytes
  1. Reverted chagnes to NormalizerTestBase.
  2. Moved RegisterSerializationClassesCompilerPassTest to tests/src/Unit
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

But we have nice subdirectories in the Unit folder, so I would suggest to move this into a CompilerPass directory there.

jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-4-6.txt665 bytes
new 2865413-6.patch916 bytes

Moved the file and updated the namespace.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Good idea to put it into a folder!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed e2554ce to 8.4.x and e82e3eb to 8.3.x. Thanks!

Test only change - committed to 8.3.x too.

  • alexpott committed e2554ce on 8.4.x 
    Issue #2865413 by Jo Fitzgerald, GoZ, klausi: Move...

  • alexpott committed e82e3eb on 8.3.x 
    Issue #2865413 by Jo Fitzgerald, GoZ, klausi: Move...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.