Problem/Motivation

\Drupal\Core\Menu\MenuLinkTree does not document its $menuLinkManager variable.

Proposed resolution

Document it! (Just like all the other variables in the there...)

Remaining tasks

User interface changes

API changes

Data model changes

Comments

tstoeckler created an issue. See original summary.

JayKandari’s picture

Assigned: Unassigned » JayKandari
JayKandari’s picture

Assigned: JayKandari » Unassigned
Status: Active » Needs review
FileSize
597 bytes

Changes applied. Kindly review!

tstoeckler’s picture

Status: Needs review » Reviewed & tested by the community

Perfect, thank you!

lauriii’s picture

Issue summary: View changes
lauriii’s picture

Issue summary: View changes

Sorry, I misread the patch :)

amit.drupal’s picture

Patch Is beautifully work.

RenatoG’s picture

Issue summary: View changes
FileSize
67.79 KB

Hi guys.

I applied the patch, study and looks good for me.

Thank you very much @jaykandari.

Good Work.

Regards.

amit.drupal’s picture

After Review Patch Submit Screenshot.

Gábor Hojtsy’s picture

  • Gábor Hojtsy committed 4e7ec88 on 8.3.x
    Issue #2865295 by JayKandari: $menuLinkManager property on MenuLinkTree...

  • Gábor Hojtsy committed 92cc819 on 8.4.x
    Issue #2865295 by JayKandari: $menuLinkManager property on MenuLinkTree...
Gábor Hojtsy’s picture

Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

Looks good, the property was already in use but was indeed undocumented. Thanks all!

penyaskito’s picture

This change introduced a probably undesired API change. Lauri was right in #5, this change changed visibility from public to protected.
I'm quite sure we don't want to revert this, but worth to notice that we may want a change record?

Gábor Hojtsy’s picture

Are undocumented object properties (which are consequentially public) part of the API as we define it? That sounds accidental :)

penyaskito’s picture

Good call, thanks :-)

penyaskito’s picture

Good call, thanks :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.