Update WYSIWYG to 2.4

The live preview test is failing because there's something going wrong when switching to the HTML editor. The toolbar isn't loading and typing in the field isn't working. I'm getting the following error in my console locally:

ReferenceError: config is not defined

This is triggered on line 101 of panopoly_magic.js, in this code block:

  // A function to run before Drupal.wysiwyg.editor.attach.markitup() with the
  // same arguments.
  function wysiwygMarkitupBeforeAttach(context, params, settings) {
    var onWysiwygChange = onWysiwygChangeFactory(params.field);
    $.each(['afterInsert', 'onEnter'], function (index, funcName) {
      config[funcName] = onWysiwygChange;
    });
  }

This might just be a typo, shouldn't it be context[funcName]? Updated patch and interdiff attached. This is working locally, but there may be some timing issues with the live preview.

The failures are due to two problems:

• The wysiwyg alter hooks in panopoly_wysiwyg.module are not being invoked. So the default button order is not set. The Media button is hidden in the third row of buttons and is not clickable during the test.
• The alt text of the button has changed from "Add media" to "Media browser."

I don't know how to fix the first problem, but I've attached a patch for panopoly_test for the 2nd problem.

Local testing looks good so far, tests are passing and functionality works as expected. We'll be doing more testing later on.

Linking some related issues that we discovered in testing:

• #2884691: "Use theme CSS" gives incorrect CSS when '#groups' array doesn't line up with child elements
• #2884450: Theme CSS not added correctly when PHP can't make HTTP requests to the site itself

@dsnopek does there need to be an update hook to handle the changed setting names? block_formats has become theme_advanced_blockformats, among other things.

Also, there are a lot of settings in the feature that no longer seem to apply to the HTML editor. When I look at admin/config/content/wysiwyg/profile/panopoly_html_text on an updated site, there are no sections for CSS or Cleanup and Output. Of course, these sections make less sense for the HTML editor. CSS only matters if you are using a WYSIWYG, and the HTML editor displays code. There are some options in the Cleanup section that make sense for a code editor, and some that don't.

I tried deleting the WYSIWYG profile for markitup and recreating it from scratch to match the previous one, using only the settings that are available in the new UI. I've attached an updated patch and interdiff with the results.

After upgrading from latest dev to dev + this patch, panopoly_wysiwyg is overridden:

$ drush fd panopoly_wysiwyg
Legend:
< Code:       drush features-revert will remove the overrides.
> Overrides:  drush features-update will update the exported feature with the displayed overrides

Component type: wysiwyg
      ),
      'settings' => array(
>       'block_formats' => 'h1,h2,h3,h4,h5,h6',
        'buttons' => array(
          'default' => array(
          ),
        ),
>       'convert_fonts_to_spans' => 1,
        'css_setting' => 'theme',
<       'css_theme' => 'responsive_bartik',
        'language' => 'en',
>       'paste_auto_cleanup_on_paste' => 1,
>       'path_loc' => 'bottom',
>       'remove_linebreaks' => 1,
>       'resizing' => 1,
>       'theme' => 'advanced',
>       'toolbar_align' => 'left',
>       'toolbar_loc' => 'top',
>       'verify_html' => 1,
      ),
    ),

This combination of patches is working as expected.