Second paragraph of current 7.x README.txt file has a missing URL replacement. The string "@url" should be the provider URL.

In order to use this module, you will need to create an API at @url

CommentFileSizeAuthor
#4 2864555-4.patch2.8 KBhardikpandya
#2 wunderground_weather-7x-readme-updates-2864555-2.patch2.8 KBChris Charlton

Comments

Chris Charlton created an issue. See original summary.

Chris Charlton’s picture

Chris Charlton
Primary language English
Location Los Angeles
commented
Title: README file @url not being replaced » README.txt updates for 7.x
Status: Active » Needs review
Issue tags: +readme, +Documentation
StatusFileSize
new wunderground_weather-7x-readme-updates-2864555-2.patch2.8 KB

This patch updates the README.txt file, fixing the bad "@url" string with a proper provider URL. Plus updated verbiage.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Needs work 
+++ b/README.txt
@@ -1,29 +1,29 @@
+http://www.wunderground.com/weather/api. You can either choose a free account ¶
+or a paid account, which allows your site to make more requests per day.
...
+Once you have obtained your API key, go to the Wunderground weather settings ¶
+page and fill in the key. Here you should also enter the language you would ¶
+like to use, and choose to use caching or not. Caching will reduce the number ¶
+of calls to Wunderground and is a lot faster. If you choose not to cache, you ¶
+will have the most up to date data in your blocks. When you have completed ¶
+the settings form, place your block(s) on the page. Configure each block by ¶

Lines 9, 10, 13, 14, 15, 16, 17, and 18 all have empty spaces at the end

typo on line 26.
WUnderground => Wunderground

hardikpandya’s picture

hardikpandya commented
Status: Needs work » Needs review
StatusFileSize
new 2864555-4.patch2.8 KB
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Reviewed & tested by the community

Looks to me as if all the comments were addressed. The empty spaces and typo have been resolved.

Patch applied using simplytest.me. Marking RTBC