I am implementing an additional response filter to add an extra Vary rule and noticed that I can not append the new header to the already set Vary: X-Authcache-Key. The reason is that $append is hardcoded in the internal call:

class AuthcacheP13nDefaultCoreService implements AuthcacheP13nCoreServiceInterface {
  public function drupalAddHttpHeader($name, $value, $append = FALSE) {
    // Right here...
    drupal_add_http_header($name, $value, $append = FALSE);
  }
  
  // ...
}

I expected AuthcacheP13nDefaultCoreService to just be a OOP wrapper for core functions, but it's already making an assumption here. IMO, it's best is to just pass whatever it got from the caller for $append.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jedihe created an issue. See original summary.

jedihe’s picture

Issue summary: View changes
znerol’s picture

Status: Active » Needs review

That looks like a stupid copy-paste error. Thanks a lot for tracking that down.

Setting to needs review in order to trigger a test-run.

  • znerol committed 3430feb on 7.x-2.x authored by jedihe
    Issue #2863461 by jedihe: Hardcoded $append=FALSE in...
znerol’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.