Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
#2670118: Make getPostLoginDestination / getPostLogoutDestination configurable started changing redirects too, however since I
* am not 100% comfortable with all aspects of the URL/redirect code
* want to change more than was present in that patch,
that part of the code has been split off into this issue.
If things start breaking, you can scold me here :-)
Comment | File | Size | Author |
---|---|---|---|
#4 | interdiff-2863340-1-3.txt | 7.34 KB | roderik |
#4 | samlauth-redirects-2863340-3.patch | 10.51 KB | roderik |
#3 | samlauth-redirects-2863340-2.patch | 10.51 KB | roderik |
#2 | samlauth-redirects-2863340-1.patch | 6.72 KB | roderik |
Comments
Comment #2
roderikBaseline: status as of #2670118-24: Make getPostLoginDestination / getPostLogoutDestination configurable with
* no_cache: TRUE added to the routing.yml (for links both before and after the redirect to the IDP);
* a large comment inserted somewhwere.
Comment #3
roderik@seanB: can you try out this patch? You'll probably need to patch the -dev version with this issue, in order to get the redirect to your external site to work. (Because I removed the following from the -dev code: #2670118-9: Make getPostLoginDestination / getPostLogoutDestination configurable. So you are the dedicated guinea pig now.)
Done:
Comment #4
roderikRenamed redirectResponseFromUrl() to createRedirectResponse(). ('redirect' is also a verb.)
Interdiff is from 1 to 3.
Comment #5
seanB#3 seems to work for me. Nice work!
Comment #6
pcambra+1 to the RTBC, looks great
Comment #7
roderikThanks all! Finally committed.