Closed (fixed)
Project:
Drupal core
Version:
8.4.x-dev
Component:
migration system
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
22 Mar 2017 at 04:30 UTC
Updated:
11 May 2017 at 14:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jofitzAdded the configuration keys and an example.
Comment #3
phenaproximaSelf-assigning for review.
Comment #4
phenaproximaThese aren't configuration keys, they're the destination properties expected in the imported row. I think we'll need to rephrase this again. Also, the property descriptions are a bit threadbare. It's not clear, for example, if entity_type is supposed to be a string. I'd suggest the following:
entity_type: The entity type ID.
bundle: The entity bundle.
view_mode: The machine name of the view mode.
field_name: The machine name of the field to be imported into the display.
options: (optional) An array of options for displaying the field in this view mode.
It's misleading to say that a field is created. How about "This will add the user_picture image field to the default view mode of user entities, with options defined by the 'options' constant (i.e., the label will be hidden, no image style will be applied, etc.)"
Comment #5
jofitzMade the changes suggested by @phenaproxima in #4.
Comment #6
phenaproximaLooks terrific!
Comment #9
gábor hojtsySuperb, thanks, looks good, committed.