Add API documentation.

See the documentation in the process plugins for format examples.

CommentFileSizeAuthor
#7 interdiff-2862744-3-7.txt999 bytesmasipila
#7 2862744-7.patch1.72 KBmasipila
#3 2862744-3.patch1.73 KBmasipila

Comments

quietone created an issue. See original summary.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

masipila’s picture

masipila commented
Status: Active » Needs review
Issue tags: +API Documentation
StatusFileSize
new 2862744-3.patch1.73 KB

Initial patch attached.

Cheers,
Markus

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work 
+++ b/core/modules/migrate/src/Plugin/migrate/destination/EntityBaseFieldOverride.php
@@ -5,7 +5,42 @@
+ * Provides entity base field override destination plugin.

I'd like to see a line explicitly calling out why "override" is in the title. I think I see the reason, but being more explicit would be helpful.

anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
commented
Issue tags: +CSKyiv18
masipila’s picture

masipila commented
Assigned: Unassigned » masipila
Issue tags: +Migrate January 2018 Sprint
masipila’s picture

masipila commented
Assigned: masipila » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2862744-7.patch1.72 KB
new interdiff-2862744-3-7.txt999 bytes

Addressed the feedback from #4.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Looks great!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

The example looks like it includes as much context info as needed clearly but not more. Thanks folks!

  • Gábor Hojtsy committed a0f31bc on 8.5.x 
    Issue #2862744 by masipila, heddn: Add documentation to...

  • Gábor Hojtsy committed 7d37e31 on 8.6.x 
    Issue #2862744 by masipila, heddn: Add documentation to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.